Refactor script

wikipedia.py

@@ -913,13 +913,11 @@ class Wikipedia(datasets.GeneratorBasedBuilder):
             citation=_CITATION,
         )
 
-    def _split_generators(self, dl_manager):
-        def _base_url(lang):
-            return _BASE_URL_TMPL.format(lang=lang.replace("-", "_"), date=self.config.date)
-
-        lang = self.config.language
+    def _get_base_url(self):
+        return _BASE_URL_TMPL.format(lang=self.config.language.replace("-", "_"), date=self.config.date)
 
-        info_url = _base_url(lang) + _INFO_FILE
+    def _split_generators(self, dl_manager):
+        info_url = self._get_base_url() + _INFO_FILE
         # Use dictionary since testing mock always returns the same result.
         downloaded_files = dl_manager.download_and_extract({"info": info_url})
 
@@ -931,7 +929,7 @@ class Wikipedia(datasets.GeneratorBasedBuilder):
         assert (
             multistream_dump_info["status"] == "done"
         ), "Specified dump (%s) multistream status is not 'done': %s" % (
-            _base_url(lang),
+            self._get_base_url(),
             multistream_dump_info["status"],
         )
 
@@ -939,7 +937,7 @@ class Wikipedia(datasets.GeneratorBasedBuilder):
             if ".xml" not in fname:
                 continue
             total_bytes += info["size"]
-            xml_urls.append(_base_url(lang) + fname)
+            xml_urls.append(self._get_base_url() + fname)
 
             # Use dictionary since testing mock always returns the same result.
         downloaded_files = dl_manager.download({"xml": xml_urls})
@@ -951,54 +949,56 @@ class Wikipedia(datasets.GeneratorBasedBuilder):
         ]
 
     def _generate_examples(self, filepaths):
-        def _extract_content(filepath):
-            """Extracts article content from a single WikiMedia XML file."""
-            logger.info("generating examples from = %s", filepath)
-            with open(filepath, "rb") as f:
-                f = bz2.BZ2File(filename=f)
-                # Workaround due to: https://github.com/tensorflow/tensorflow/issues/33563
-                utf_f = codecs.getreader("utf-8")(f)
-                context = etree.iterparse(utf_f, events=("end",))
-                for unused_event, elem in context:
-                    if not elem.tag.endswith("page"):
-                        continue
-                    namespace = elem.tag[:-4]
-                    title = elem.find(f"./{namespace}title").text
-                    ns = elem.find(f"./{namespace}ns").text
-                    id_ = elem.find(f"./{namespace}id").text
-                    red_ = elem.find(f"./{namespace}redirect")
+        # No shuffle anymore
+        for filepath in filepaths:
+            for id_, title, raw_content in _extract_content(filepath):
+                yield from _clean_content((id_, title, raw_content), self.config.language)
+
 
-                    # Filter pages that are not in the "main" namespace.
-                    if ns != "0":
-                        elem.clear()
-                        continue
+def _extract_content(filepath):
+    """Extracts article content from a single WikiMedia XML file."""
+    logger.info("generating examples from = %s", filepath)
+    with open(filepath, "rb") as f:
+        f = bz2.BZ2File(filename=f)
+        # Workaround due to: https://github.com/tensorflow/tensorflow/issues/33563
+        utf_f = codecs.getreader("utf-8")(f)
+        context = etree.iterparse(utf_f, events=("end",))
+        for unused_event, elem in context:
+            if not elem.tag.endswith("page"):
+                continue
+            namespace = elem.tag[:-4]
+            title = elem.find(f"./{namespace}title").text
+            ns = elem.find(f"./{namespace}ns").text
+            id_ = elem.find(f"./{namespace}id").text
+            red_ = elem.find(f"./{namespace}redirect")
 
-                    raw_content = elem.find(f"./{namespace}revision/{namespace}text").text
-                    elem.clear()
+            # Filter pages that are not in the "main" namespace.
+            if ns != "0":
+                elem.clear()
+                continue
 
-                    # Filter redirects.
-                    if raw_content is None or red_ is not None:
-                        continue
+            raw_content = elem.find(f"./{namespace}revision/{namespace}text").text
+            elem.clear()
 
-                    yield id_, title, raw_content
+            # Filter redirects.
+            if raw_content is None or red_ is not None:
+                continue
 
-        def _clean_content(inputs, language):
-            """Cleans raw wikicode to extract text."""
-            id_, title, raw_content = inputs
-            try:
-                text = _parse_and_clean_wikicode(raw_content, parser=mwparserfromhell, language=language)
-            except mwparserfromhell.parser.ParserError as e:
-                logger.error("mwparserfromhell ParseError: %s", e)
-                return
-            if not text:
-                return
-            url = _construct_url(title, language)
-            yield id_, {"id": id_, "url": url, "title": title, "text": text}
+            yield id_, title, raw_content
 
-        # No shuffle anymore
-        for filepath in filepaths:
-            for id_, title, raw_content in _extract_content(filepath):
-                yield from _clean_content((id_, title, raw_content), self.config.language)
+
+def _clean_content(inputs, language):
+    """Cleans raw wikicode to extract text."""
+    id_, title, raw_content = inputs
+    try:
+        text = _parse_and_clean_wikicode(raw_content, parser=mwparserfromhell, language=language)
+    except mwparserfromhell.parser.ParserError as e:
+        logger.error("mwparserfromhell ParseError: %s", e)
+        return
+    if not text:
+        return
+    url = _construct_url(title, language)
+    yield id_, {"id": id_, "url": url, "title": title, "text": text}
 
 
 def _parse_and_clean_wikicode(raw_content, parser, language):