commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Add various assertions to heap pruning code.
These assertions document (and verify) our high level assumptions about
how pruning can and cannot affect existing items from target heap pages.
For example, one of the new assertions verifies that pruning does not
set a heap-only tuple to LP_DEAD.
Author: Peter Geoghegan <[email protected]>
Reviewed-By: Andres Freund <[email protected]>
Discussion: https://postgr.es/m/CAH2-Wz=vhvBx1GjF+oueHh8YQcHoQYrMi0F0zFMHEr8yc4sCoA@mail.gmail.com
| 5cd7eb1f1c32e1b95894f28b277b4e4b89add772 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/5cd7eb1f1c32e1b95894f28b277b4e4b89add772 | 2021-11-04 19:07:54-07:00 |
Fix for checksum validation patch
Reorder the check for non-BLCKSZ size reads to make sure we don't abort
sending the file in this case.
Missed in the previous commit.
| a08dc711952081d63577fc182fcf955958f70add | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/a08dc711952081d63577fc182fcf955958f70add | 2018-04-03 13:57:49+02:00 |
Fix instability in 026_overwrite_contrecord.pl test.
We've seen intermittent failures in this test on slower buildfarm
machines, which I think can be explained by assuming that autovacuum
emitted some additional WAL. Disable autovacuum to stabilize it.
In passing, use stringwise not numeric comparison to compare
WAL file names. Doesn't matter at present, but they are
hex strings not decimal ...
Discussion: https://postgr.es/m/[email protected]
| b66767b56b1cd082f3499a7e5a21b480dd004f51 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/b66767b56b1cd082f3499a7e5a21b480dd004f51 | 2021-11-09 18:40:19-05:00 |
Add ALTER EXTENSION ADD/DROP ACCESS METHOD, and use it in pg_upgrade.
Without this, an extension containing an access method is not properly
dumped/restored during pg_upgrade --- the AM ends up not being a member
of the extension after upgrading.
Another oversight in commit 473b93287, reported by Andrew Dunstan.
Report: <[email protected]>
| e8bdee2770ff52aab208bc6f8965a4a01979d0aa | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/e8bdee2770ff52aab208bc6f8965a4a01979d0aa | 2016-10-02 14:31:28-04:00 |
Allow pg_dumpall to dump roles w/o user passwords
Add new option --no-role-passwords which dumps roles without passwords.
Since we don’t need passwords, we choose to use pg_roles in preference
to pg_authid since access may be restricted for security reasons in
some configrations.
Robins Tharakan and Simon Riggs
| 9a83d56b38c870ce47b7651385ff2add583bf136 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/9a83d56b38c870ce47b7651385ff2add583bf136 | 2017-03-07 22:00:54+08:00 |
Fix thinko in new ECPG "PREPARE AS" code.
ecpg_register_prepared_stmt() is pretty obviously checking the wrong
variable while trying to detect malloc failure. Error in commit
a1dc6ab46, spotted by Coverity.
| 331695a4d9ca40864240aca721dc588a206ff395 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/331695a4d9ca40864240aca721dc588a206ff395 | 2019-05-26 10:06:37-04:00 |
doc: Fix typo
Author: Justin Pryzby <[email protected]>
| ef6576f5379edfa29bb4f99880b0f76dd315dd14 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/ef6576f5379edfa29bb4f99880b0f76dd315dd14 | 2019-03-30 17:25:13+01:00 |
Fix typo in sources.sgml.
Per Shinichi Matsuda.
| 36d154ecb2286328c7c59b99d5abb71318e056eb | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/36d154ecb2286328c7c59b99d5abb71318e056eb | 2016-10-31 07:30:46+09:00 |
Remove AssertArg and AssertState
These don't offer anything over plain Assert, and their usage had
already been declared obsolescent.
Author: Nathan Bossart <[email protected]>
Reviewed-by: Michael Paquier <[email protected]>
Discussion: https://www.postgresql.org/message-id/20221009210148.GA900071@nathanxps13
| b1099eca8f38ff5cfaf0901bb91cb6a22f909bc6 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/b1099eca8f38ff5cfaf0901bb91cb6a22f909bc6 | 2022-10-28 09:19:06+02:00 |
Prevent overly-aggressive collapsing of joins to RTE_RESULT relations.
The RTE_RESULT simplification logic added by commit 4be058fe9 had a
flaw: it would collapse out a RTE_RESULT that is due to compute a
PlaceHolderVar, and reassign the PHV to the parent join level, even if
another input relation of the join contained a lateral reference to
the PHV. That can't work because the PHV would be computed too late.
In practice it led to failures of internal sanity checks later in
planning (either assertion failures or errors such as "failed to
construct the join relation").
To fix, add code to check for the presence of such PHVs in relevant
portions of the query tree. Notably, this required refactoring
range_table_walker so that a caller could ask to walk individual RTEs
not the whole list. (It might be a good idea to refactor
range_table_mutator in the same way, if only to keep those functions
looking similar; but I didn't do so here as it wasn't necessary for
the bug fix.)
This exercise also taught me that find_dependent_phvs(), as it stood,
could only safely be used on the entire Query, not on subtrees.
Adjust its API to reflect that; which in passing allows it to have
a fast path for the common case of no PHVs anywhere.
Per report from Will Leinweber. Back-patch to v12 where the bug
was introduced.
Discussion: https://postgr.es/m/CALLb-4xJMd4GZt2YCecMC95H-PafuWNKcmps4HLRx2NHNBfB4g@mail.gmail.com
| 6ea364e7e7d5f298fc965006caa6c228c743fe77 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/6ea364e7e7d5f298fc965006caa6c228c743fe77 | 2019-12-14 13:49:15-05:00 |
Fix logical replication to fire BEFORE ROW DELETE triggers.
Before, that would fail to happen unless a BEFORE ROW UPDATE trigger
was also present.
Noted by me while reviewing a patch from Masahiko Sawada, who also
wrote this patch. Reviewed by Petr Jelinek.
Discussion: http://postgr.es/m/CA+TgmobAZvCxduG8y_mQKBK7nz-vhbdLvjM354KEFozpuzMN5A@mail.gmail.com
| 360fd1a7b2fe779cc9e696b813b12f6a8e83b558 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/360fd1a7b2fe779cc9e696b813b12f6a8e83b558 | 2017-10-12 10:09:26-04:00 |
Fix error in documentated use of mingw-w64 compilers
Error reported by Igal Sapir.
| 7dc09c138493424e32876894c2c68ddecff3afc6 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/7dc09c138493424e32876894c2c68ddecff3afc6 | 2016-01-30 19:28:44-05:00 |
Doc: add comments about PreventInTransactionBlock/IsInTransactionBlock.
Add a little to the header comments for these functions to make it
clearer what guarantees about commit behavior are provided to callers.
(See commit f92944137 for context.)
Although this is only a comment change, it's really documentation
aimed at authors of extensions, so it seems appropriate to back-patch.
Yugo Nagata and Tom Lane, per further discussion of bug #17434.
Discussion: https://postgr.es/m/[email protected]
| e613ace1f0d5734b62b133e9700300166ece1599 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/e613ace1f0d5734b62b133e9700300166ece1599 | 2022-11-09 11:08:52-05:00 |
Correct pg_indent to pgindent in various comments.
David Christensen
| fd5eaad71529d508a1b1e411b3dc16e0b2d33da5 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/fd5eaad71529d508a1b1e411b3dc16e0b2d33da5 | 2015-10-08 12:24:51-04:00 |
Fix incorrect function reference in comment of twophase.c
The header block of TwoPhaseGetDummyBackendId mentioned incorrectly
TwoPhaseGetDummyProc.
Reported-by: Oleksii Kliukin
Discussion: https://postgr.es/m/[email protected]
| 4c23216002ac816f67fb87301290fa992115215e | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/4c23216002ac816f67fb87301290fa992115215e | 2019-02-23 08:40:01+09:00 |
Fix mishandling of NaN counts in numeric_[avg_]combine.
When merging two NumericAggStates, the code missed adding the new
state's NaNcount unless its N was also nonzero; since those counts
are independent, this is wrong.
This would only have visible effect if some partial aggregate scans
found only NaNs while earlier ones found only non-NaNs; then we could
end up falsely deciding that there were no NaNs and fail to return a
NaN final result as expected. That's pretty improbable, so it's no
surprise this hasn't been reported from the field. Still, it's a bug.
I didn't try to produce a regression test that would show the bug,
but I did notice that these functions weren't being reached at all
in our regression tests, so I improved the tests to at least
exercise them. With these additions, I see pretty complete code
coverage on the aggregation-related functions in numeric.c.
Back-patch to 9.6 where this code was introduced. (I only added
the improved test case as far back as v10, though, since the
relevant part of aggregates.sql isn't there at all in 9.6.)
| 77a3be32f7c16538bc4e05edad85560d9f88369b | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/77a3be32f7c16538bc4e05edad85560d9f88369b | 2020-06-11 17:38:42-04:00 |
Fix interaction of Perl and stdbool.h
Revert the PL/Perl-specific change in
9a95a77d9d5d3003d2d67121f2731b6e5fc37336. We must not prevent Perl from
using stdbool.h when it has been built to do so, even if it uses an
incompatible size. Otherwise, we would be imposing our bool on Perl,
which will lead to crashes because of the size mismatch.
Instead, we undef bool after including the Perl headers, as we did
previously, but now only if we are not using stdbool.h ourselves.
Record that choice in c.h as USE_STDBOOL. This will also make it easier
to apply that coding pattern elsewhere if necessary.
| 7ba7986fb4364e889a705c9973fefa138650091c | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/7ba7986fb4364e889a705c9973fefa138650091c | 2018-03-23 10:31:10-04:00 |
Detach constraints when partitions are detached
I (Álvaro) forgot to do this in eb7ed3f30634, leading to undroppable
constraints after partitions are detached. Repair.
Reported-by: Amit Langote
Author: Amit Langote
Discussion: https://postgr.es/m/[email protected]
| ae366aa57762ad0e6a1a0885a7644e79541afe39 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/ae366aa57762ad0e6a1a0885a7644e79541afe39 | 2019-01-23 23:57:46-03:00 |
Add trigonometric functions that work in degrees.
The implementations go to some lengths to deliver exact results for values
where an exact result can be expected, such as sind(30) = 0.5 exactly.
Dean Rasheed, reviewed by Michael Paquier
| e1bd684a34c11139a1bf4e5200c3bbe59a0fbfad | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/e1bd684a34c11139a1bf4e5200c3bbe59a0fbfad | 2016-01-22 15:46:22-05:00 |
cirrus/ccache: Use G rather than GB suffix
The former being the documented spelling.
Author: Justin Pryzby <[email protected]>
Discussion: https://www.postgresql.org/message-id/20230203142656.GA1653%40telsasoft.com
| bf32ec225635cbdf15b11cbdc8553e3355cc52ba | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/bf32ec225635cbdf15b11cbdc8553e3355cc52ba | 2023-03-13 07:23:45+01:00 |
Improve comments and logs in do_pg_stop/start_backup
The function name pg_stop_backup() has been included for ages in some
log messages when stopping the backup, which is confusing for base
backups taken with the replication protocol because this function is
never called. Some other comments and messages in this area are
improved while on it.
The new wording is based on input and suggestions from several people,
all listed below.
Author: Michael Paquier
Reviewed-by: Peter Eisentraut, Álvaro Herrera, Tom Lane
Discussion: https://postgr.es/m/[email protected]
| 8d3b389ec3405659d8e2968fc6179b28b286ccd8 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/8d3b389ec3405659d8e2968fc6179b28b286ccd8 | 2019-01-01 08:53:02+09:00 |
Add missing support for the latest SPI status codes.
SPI_result_code_string() was missing support for SPI_OK_TD_REGISTER,
and in v15 and later, it was missing support for SPI_OK_MERGE, as was
pltcl_process_SPI_result().
The last of those would trigger an error if a MERGE was executed from
PL/Tcl. The others seem fairly innocuous, but worth fixing.
Back-patch to all supported branches. Before v15, this is just adding
SPI_OK_TD_REGISTER to SPI_result_code_string(), which is unlikely to
be seen by anyone, but seems worth doing for completeness.
Reviewed by Tom Lane.
Discussion:
https://postgr.es/m/CAEZATCUg8V%2BK%2BGcafOPqymxk84Y_prXgfe64PDoopjLFH6Z0Aw%40mail.gmail.com
https://postgr.es/m/CAEZATCUMe%2B_KedPMM9AxKqm%3DSZogSxjUcrMe%2BsakusZh3BFcQw%40mail.gmail.com
| d0460a31de6acc8bbb86e9e3d646f1113ebb0c20 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/d0460a31de6acc8bbb86e9e3d646f1113ebb0c20 | 2023-02-22 13:23:09+00:00 |
Fix corner-case uninitialized-variable issues in plpgsql.
If an error was raised during our initial attempt to check whether
a successfully-compiled expression is "simple", subsequent calls of
exec_stmt_execsql would suppose that stmt->mod_stmt was already computed
when it had not been. This could lead to assertion failures in debug
builds; in production builds the effect would typically be to act as
if INTO STRICT had been specified even when it had not been. Of course
that only matters if the subsequent attempt to execute the expression
succeeds, so that the problem can only be reached by fixing a failure
in some referenced, inline-able SQL function and then retrying the
calling plpgsql function in the same session.
(There might be even-more-obscure ways to change the expression's
behavior without changing the plpgsql function, but that one seems
like the only one people would be likely to hit in practice.)
The most foolproof way to fix this would be to arrange for
exec_prepare_plan to not set expr->plan until we've finished the
subsidiary simple-expression check. But it seems hard to do that
without creating reference-count leak issues. So settle for documenting
the hazard in a comment and fixing exec_stmt_execsql to test separately
for whether it's computed stmt->mod_stmt. (That adds a test-and-branch
per execution, but hopefully that's negligible in context.) In v11 and
up, also fix exec_stmt_call which had a variant of the same issue.
Per bug #17113 from Alexander Lakhin. Back-patch to all
supported branches.
Discussion: https://postgr.es/m/[email protected]
| d9809bf8694c17e05537c5dd96cde3e67c02d52a | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/d9809bf8694c17e05537c5dd96cde3e67c02d52a | 2021-07-20 13:01:48-04:00 |
Add PQencryptPasswordConn function to libpq, use it in psql and createuser.
The new function supports creating SCRAM verifiers, in addition to md5
hashes. The algorithm is chosen based on password_encryption, by default.
This fixes the issue reported by Jeff Janes, that there was previously
no way to create a SCRAM verifier with "\password".
Michael Paquier and me
Discussion: https://www.postgresql.org/message-id/CAMkU%3D1wfBgFPbfAMYZQE78p%3DVhZX7nN86aWkp0QcCp%3D%2BKxZ%3Dbg%40mail.gmail.com
| 8f8b9be51fd788bb11276df89606bc653163524e | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/8f8b9be51fd788bb11276df89606bc653163524e | 2017-05-03 11:19:07+03:00 |
Fix Parallel Append crash.
Reported by Tom Lane and the buildfarm.
Amul Sul and Amit Khandekar
Discussion: http://postgr.es/m/[email protected]
Discussion: http://postgr.es/m/CAJ3gD9cJQ4d-XhmZ6BqM9rMM2KDBfpkdgOAb4+psz56uBuMQ_A@mail.gmail.com
| 9c64ddd414855fb10e0355e887745270a4464c50 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/9c64ddd414855fb10e0355e887745270a4464c50 | 2017-12-06 08:42:50-05:00 |
Avoid overflow hazard when clamping group counts to "long int".
Several places in the planner tried to clamp a double value to fit
in a "long" by doing
(long) Min(x, (double) LONG_MAX);
This is subtly incorrect, because it casts LONG_MAX to double and
potentially back again. If long is 64 bits then the double value
is inexact, and the platform might round it up to LONG_MAX+1
resulting in an overflow and an undesirably negative output.
While it's not hard to rewrite the expression into a safe form,
let's put it into a common function to reduce the risk of someone
doing it wrong in future.
In principle this is a bug fix, but since the problem could only
manifest with group count estimates exceeding 2^63, it seems unlikely
that anyone has actually hit this or will do so anytime soon. We're
fixing it mainly to satisfy fuzzer-type tools. That being the case,
a HEAD-only fix seems sufficient.
Andrey Lepikhov
Discussion: https://postgr.es/m/[email protected]
| a916cb9d5a89804998dd4e7fd7bbb27cb5a7abc8 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/a916cb9d5a89804998dd4e7fd7bbb27cb5a7abc8 | 2022-05-21 13:13:41-04:00 |
Add an explicit representation of the output targetlist to Paths.
Up to now, there's been an assumption that all Paths for a given relation
compute the same output column set (targetlist). However, there are good
reasons to remove that assumption. For example, an indexscan on an
expression index might be able to return the value of an expensive function
"for free". While we have the ability to generate such a plan today in
simple cases, we don't have a way to model that it's cheaper than a plan
that computes the function from scratch, nor a way to create such a plan
in join cases (where the function computation would normally happen at
the topmost join node). Also, we need this so that we can have Paths
representing post-scan/join steps, where the targetlist may well change
from one step to the next. Therefore, invent a "struct PathTarget"
representing the columns we expect a plan step to emit. It's convenient
to include the output tuple width and tlist evaluation cost in this struct,
and there will likely be additional fields in future.
While Path nodes that actually do have custom outputs will need their own
PathTargets, it will still be true that most Paths for a given relation
will compute the same tlist. To reduce the overhead added by this patch,
keep a "default PathTarget" in RelOptInfo, and allow Paths that compute
that column set to just point to their parent RelOptInfo's reltarget.
(In the patch as committed, actually every Path is like that, since we
do not yet have any cases of custom PathTargets.)
I took this opportunity to provide some more-honest costing of
PlaceHolderVar evaluation. Up to now, the assumption that "scan/join
reltargetlists have cost zero" was applied not only to Vars, where it's
reasonable, but also PlaceHolderVars where it isn't. Now, we add the eval
cost of a PlaceHolderVar's expression to the first plan level where it can
be computed, by including it in the PathTarget cost field and adding that
to the cost estimates for Paths. This isn't perfect yet but it's much
better than before, and there is a way forward to improve it more. This
costing change affects the join order chosen for a couple of the regression
tests, changing expected row ordering.
| 19a541143a09c067ec8cac77ec6a64eb5b1b662b | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/19a541143a09c067ec8cac77ec6a64eb5b1b662b | 2016-02-18 20:01:49-05:00 |
Accept fractional seconds in jsonpath's datetime() method.
Commit 927d9abb6 purported to make datetime() accept any string
that could be output for a datetime value by to_jsonb(). But it
overlooked the possibility of fractional seconds being present,
so that cases as simple as to_jsonb(now()) would defeat it.
Fix by adding formats that include ".US" to the list in
executeDateTimeMethod(). (Note that while this is nominally
microseconds, it'll do the right thing for fractions with
fewer than six digits.)
In passing, re-order the list to restore the datatype ordering
specified in its comment. The violation accidentally did not
break anything; but the next edit might be less lucky, so add
more comments.
Per report from Tim Field. Back-patch to v13 where datetime()
was added, like the previous patch.
Discussion: https://postgr.es/m/[email protected]
| 7398e27224f173306e5b62977672b29f5553ee76 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/7398e27224f173306e5b62977672b29f5553ee76 | 2023-06-12 10:54:28-04:00 |
Add %x to default PROMPT1 and PROMPT2 in psql
%d can be used to track if the current connection is in a transaction
block or not, and adding it by default to the prompt has the advantage
to not need a modification of .psqlrc, something not possible depending
on the environment.
This discussion has happened across various sources, and there was a
strong consensus in favor of this change.
Author: Vik Fearing
Reviewed-by: Fabien Coelho
Discussion: https://postgr.es/m/[email protected]
| dcdbb5a5db09064ac08ff3971c5031281ef2e545 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/dcdbb5a5db09064ac08ff3971c5031281ef2e545 | 2020-02-12 13:31:14+09:00 |
Adapt to LLVM 7+ Orc API changes.
This is mostly done to be able to validate features and fixes
submitted to LLVM. Given the size of these changes that seems
acceptable.
Author: Andres Freund
| 4b9094eb6e14dfdbed61278ea8e51cc846e43579 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/4b9094eb6e14dfdbed61278ea8e51cc846e43579 | 2018-03-26 15:55:16-07:00 |
AIX: Test the -qlonglong option before use.
xlc provides "long long" unconditionally at C99-compatible language
levels, and this option provokes a warning. The warning interferes with
"configure" tests that fail in response to any warning. Notably, before
commit 85a2a8903f7e9151793308d0638621003aded5ae, it interfered with the
test for -qnoansialias. Back-patch to 9.0 (all supported versions).
| 43d89a23d59c487bc9258fad7a6187864cb8c0c0 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/43d89a23d59c487bc9258fad7a6187864cb8c0c0 | 2015-07-17 03:01:14-04:00 |
Actually pick .lib file when multiple perl libs are present
7240962f8626ff09bb8f9e71ecdb074775bdd035 got it right in the comment,
but the code did not actually do what the comment said. Fix that.
Issue pointed out by Noah Misch.
| 6946280cded903b6f5269fcce105f8ab1d455d33 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/6946280cded903b6f5269fcce105f8ab1d455d33 | 2018-03-04 18:00:16+01:00 |
Add "pg_database_owner" default role.
Membership consists, implicitly, of the current database owner. Expect
use in template databases. Once pg_database_owner has rights within a
template, each owner of a database instantiated from that template will
exercise those rights.
Reviewed by John Naylor.
Discussion: https://postgr.es/m/[email protected]
| a14a0118a1fecf4066e53af52ed0f188607d0c4b | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/a14a0118a1fecf4066e53af52ed0f188607d0c4b | 2021-03-26 10:42:17-07:00 |
Fix spelling errors and typos in comments
Author: Daniel Gustafsson <[email protected]>
| fbec7459aa39da864ad1d578f044a21c3b3b057c | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/fbec7459aa39da864ad1d578f044a21c3b3b057c | 2018-11-02 13:56:16+01:00 |
Fix rare startup failure induced by MVCC-catalog-scans patch.
While a new backend nominally participates in sinval signaling starting
from the SharedInvalBackendInit call near the top of InitPostgres, it
cannot recognize sinval messages for unshared catalogs of its database
until it has set up MyDatabaseId. This is not problematic for the catcache
or relcache, which by definition won't have loaded any data from or about
such catalogs before that point. However, commit 568d4138c646cd7c
introduced a mechanism for re-using MVCC snapshots for catalog scans, and
made invalidation of those depend on recognizing relevant sinval messages.
So it's possible to establish a catalog snapshot to read pg_authid and
pg_database, then before we set MyDatabaseId, receive sinval messages that
should result in invalidating that snapshot --- but do not, because we
don't realize they are for our database. This mechanism explains the
intermittent buildfarm failures we've seen since commit 31eae6028eca4365.
That commit was not itself at fault, but it introduced a new regression
test that does reconnections concurrently with the "vacuum full pg_am"
command in vacuum.sql. This allowed the pre-existing error to be exposed,
given just the right timing, because we'd fail to update our information
about how to access pg_am. In principle any VACUUM FULL on a system
catalog could have created a similar hazard for concurrent incoming
connections. Perhaps there are more subtle failure cases as well.
To fix, force invalidation of the catalog snapshot as soon as we've
set MyDatabaseId.
Back-patch to 9.4 where the error was introduced.
| bc49d9324a464fce8f60e1bc14531631883021d4 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/bc49d9324a464fce8f60e1bc14531631883021d4 | 2015-04-03 00:07:29-04:00 |
Use appropriate wait event when sending data in the apply worker.
Currently, we reuse WAIT_EVENT_LOGICAL_PARALLEL_APPLY_STATE_CHANGE in the
apply worker while sending data to the parallel apply worker via a shared
memory queue. This is not appropriate as one won't be able to distinguish
whether the worker is waiting for sending data or for the state change.
To patch instead uses the wait event WAIT_EVENT_MQ_SEND which has been
already used in blocking mode while sending data via a shared memory
queue.
Author: Hou Zhijie
Reviewed-by: Kuroda Hayato, Amit Kapila
Discussion: https://postgr.es/m/OS0PR01MB57161C680B22E4C591628EE994DA9@OS0PR01MB5716.jpnprd01.prod.outlook.com
| d9d7fe68d35e1e10c7c8276d07f5abf9c477cb13 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/d9d7fe68d35e1e10c7c8276d07f5abf9c477cb13 | 2023-02-07 09:58:19+05:30 |
Fix typo in tab-complete.c
Introduced in b048326.
Reported-by: Jeff Davis
Discussion: https://postgr.es/m/[email protected]
| 15c6ede04577f856f702bf0a032297de667f382a | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/15c6ede04577f856f702bf0a032297de667f382a | 2021-07-29 14:49:48+09:00 |
Revert recent changes to 002_pg_upgrade.pl.
The test is proving to be unreliable in the buildfarm, and we neither
agree on how best to fix it nor have time to do so before the upcoming
release. So for now, put things back to the way they were before commit
d498e052b4b84ae21b3b68d5b3fda6ead65d1d4d.
Discussion: http://postgr.es/m/[email protected]
| 87e22f675fd81ba1d96b0b9a34bbf26d5ec532d5 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/87e22f675fd81ba1d96b0b9a34bbf26d5ec532d5 | 2022-08-04 15:17:14-04:00 |
Add output file argument to generate-errcodes.pl
This is in preparation for building postgres with meson / ninja.
meson's 'capture' (redirecting stdout to a file) is a bit slower than programs
redirecting output themselves (mostly due to a python wrapper necessary for
windows). That doesn't matter for most things, but errcodes.h is a dependency
of nearly everything, making it a bit faster seem worthwhile.
Medium term it might also be worth avoiding writing errcodes.h if its contents
didn't actually change, to avoid unnecessary recompilations.
Reviewed-by: Peter Eisentraut <[email protected]>
Discussion: https://postgr.es/m/[email protected]
| 2bf626b714b5189d6041c228f74cdb769ea169fa | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/2bf626b714b5189d6041c228f74cdb769ea169fa | 2022-07-18 12:15:09-07:00 |
Fix bugs in libpq's GSSAPI encryption support.
The critical issue fixed here is that if a GSSAPI-encrypted connection
is successfully made, pqsecure_open_gss() cleared conn->allow_ssl_try,
as an admittedly-hacky way of preventing us from then trying to tunnel
SSL encryption over the already-encrypted connection. The problem
with that is that if we abandon the GSSAPI connection because of a
failure during authentication, we would not attempt SSL encryption
in the next try with the same server. This can lead to unexpected
connection failure, or silently getting a non-encrypted connection
where an encrypted one is expected.
Fortunately, we'd only manage to make a GSSAPI-encrypted connection
if both client and server hold valid tickets in the same Kerberos
infrastructure, which is a relatively uncommon environment.
Nonetheless this is a very nasty bug with potential security
consequences. To fix, don't reset the flag, instead adding a
check for conn->gssenc being already true when deciding whether
to try to initiate SSL.
While here, fix some lesser issues in libpq's GSSAPI code:
* Use the need_new_connection stanza when dropping an attempted
GSSAPI connection, instead of partially duplicating that code.
The consequences of this are pretty minor: AFAICS it could only
lead to auth_req_received or password_needed remaining set when
they shouldn't, which is not too harmful.
* Fix pg_GSS_error() to not repeat the "mprefix" it's given multiple
times, and to notice any failure return from gss_display_status().
* Avoid gratuitous dependency on NI_MAXHOST in
pg_GSS_load_servicename().
Per report from Mikael Gustavsson. Back-patch to v12 where
this code was introduced.
Discussion: https://postgr.es/m/[email protected]
| ff6ce9a3a691a96e8e47ed449bc51c5a178e6931 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/ff6ce9a3a691a96e8e47ed449bc51c5a178e6931 | 2020-12-28 15:43:44-05:00 |
Make TestLib::perl2host more consistent and robust
Sometimes cygpath has been observed to return a path with a trailing
slash. That can cause problems, Also, make "cygpath" usage
consistent with "pwd -W" with respect to the use of forward slashes.
Backpatch to release 14 where the current code was introduced.
| bad106752272c05de5a56036b8a84ae6ff3249a0 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/bad106752272c05de5a56036b8a84ae6ff3249a0 | 2021-07-29 12:15:03-04:00 |
Stabilize incremental_sort tests
The test never did ANALYZE on the test table, so the plans depended on
various defaults (e.g. number of groups being 200). This worked most of
the time, but with CLOBBER_CACHE_ALWAYS the autoanalyze often managed
to build accurate stats, changing the plan.
Fixed by increasing the size of test tables a bit, making the Sort a bit
more expensive than Incremental Sort. The tests were constructed to test
transitions in the Incremental Sort algorithm, and this change does not
break that.
Reviewed-by: James Coleman
Discussion: https://postgr.es/m/CAPpHfds1waRZ=NOmueYq0sx1ZSCnt+5QJvizT8ndT2=etZEeAQ@mail.gmail.com
| cea09246e57821b8a97a6483a7df6c7345b055ef | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/cea09246e57821b8a97a6483a7df6c7345b055ef | 2020-04-08 18:30:11+02:00 |
Validate the OID argument of pg_import_system_collations().
"SELECT pg_import_system_collations(0)" caused an assertion failure.
With a random nonzero argument --- or indeed with zero, in non-assert
builds --- it would happily make pg_collation entries with garbage
values of collnamespace. These are harmless as far as I can tell
(unless maybe the OID happens to become used for a schema, later on?).
In any case this isn't a security issue, since the function is
superuser-only. But it seems like a gotcha for unwary DBAs, so let's
add a check that the given OID belongs to some schema.
Back-patch to v10 where this function was introduced.
| 5c06abb9b97b69513a3998cccf89556e73052e02 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/5c06abb9b97b69513a3998cccf89556e73052e02 | 2021-03-08 18:21:51-05:00 |
pg_checksums: data_checksum_version is unsigned so use %u not %d
While the previous behavior didn't generate a warning, we might as well
use an accurate *printf specification.
Backpatch-through: 12
| 888671a8cda5896d36d3ec523e201ab6a11e1855 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/888671a8cda5896d36d3ec523e201ab6a11e1855 | 2020-12-01 20:27:06-05:00 |
Fix possible crash reading pg_stat_activity.
With the old code, a backend that read pg_stat_activity without ever
having executed a parallel query might see a backend in the midst of
executing one waiting on a DSA LWLock, resulting in a crash. The
solution is for backends to register the tranche at startup time, not
the first time a parallel query is executed.
Report by Andreas Seltenreich. Patch by me, reviewed by Thomas Munro.
| 175ff6598e014b2fe84c06fa443161294fc2eed0 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/175ff6598e014b2fe84c06fa443161294fc2eed0 | 2017-01-05 12:27:09-05:00 |
Add missing break out seqscan loop in logical replication
When replica identity is FULL (an admittedly unusual case), the loop
that searches for tuples in execReplication.c didn't stop scanning the
table when once a matching tuple was found. Add the missing 'break'.
Note slight behavior change: we now return the first matching tuple
rather than the last one. They are supposed to be indistinguishable
anyway, so this shouldn't matter.
Author: Konstantin Knizhnik
Discussion: https://postgr.es/m/[email protected]
| 1c7a0b387d18c517d45e2f6ec7d8b7d1b2d5fe13 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/1c7a0b387d18c517d45e2f6ec7d8b7d1b2d5fe13 | 2020-02-03 18:59:12-03:00 |
Add pg_depend.refobjversion.
Provide a place for the version of referenced database objects to be
recorded. A follow-up commit will use this to record dependencies on
collation versions for indexes, but similar ideas for other kinds of
objects have also been mooted.
Author: Thomas Munro <[email protected]>
Reviewed-by: Julien Rouhaud <[email protected]>
Reviewed-by: Peter Eisentraut <[email protected]>
Discussion: https://postgr.es/m/CAEepm%3D0uEQCpfq_%2BLYFBdArCe4Ot98t1aR4eYiYTe%3DyavQygiQ%40mail.gmail.com
| cd6f479e79f3a33ef7a919c6b6c0c498c790f154 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/cd6f479e79f3a33ef7a919c6b6c0c498c790f154 | 2020-11-02 19:40:49+13:00 |
Implement SortSupport for macaddr data type
Introduces a scheme to produce abbreviated keys for the macaddr type.
Bump catalog version.
Author: Brandur Leach
Reviewed-by: Julien Rouhaud, Peter Geoghegan
https://commitfest.postgresql.org/13/743/
| f90d23d0c51895e0d7db7910538e85d3d38691f0 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/f90d23d0c51895e0d7db7910538e85d3d38691f0 | 2017-03-29 23:28:56+03:00 |
MSVC: Remove any tmp_check directory before running a TAP test suite.
Back-patch to v11, where commit 90627cf98a8e7d0531789391fd798c9bfcc3bc1a
made the GNU make build system do likewise. Without this, when a
typical PostgresNode-using test failed, subsequent runs bailed out with
a "File exists" error.
| a53f0edd64d0b11abc4a87681ba85669ae90ce1f | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/a53f0edd64d0b11abc4a87681ba85669ae90ce1f | 2018-08-19 01:12:22-07:00 |
Print WAL position correctly in pg_rewind error message.
This has been wrong ever since pg_rewind was added. The if-branch just
above this, where we print the same error with an extra message supplied
by XLogReadRecord() got this right, but the variable name was wrong in the
else-branch. As a consequence, the error printed the WAL position as
0/0 if there was an error reading a WAL file.
Backpatch to 9.5, where pg_rewind was added.
| d8b094dabb0fa16388340ca823d0a38285d2d6ce | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/d8b094dabb0fa16388340ca823d0a38285d2d6ce | 2019-07-30 21:14:14+03:00 |
A small tweak to some comments for PartitionKeyData
It was not really that obvious that there's meant to be exactly 1 item
in the partexprs List for each zero-valued partattrs element. Some
incorrect code using these fields was the cause of CVE-2018-1052, so
it's worthwhile to mention how they should be used in the comments.
Author: David Rowley <[email protected]>
| 7ac0069fb880b9b64223f104058c82773321851c | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/7ac0069fb880b9b64223f104058c82773321851c | 2018-11-15 23:22:19+01:00 |
Add support for building with ZSTD.
This commit doesn't actually add anything that uses ZSTD; that will be
done separately. It just puts the basic infrastructure into place.
Jeevan Ladhe, Robert Haas, and Michael Paquier. Reviewed by Justin
Pryzby and Andres Freund.
Discussion: http://postgr.es/m/CA+TgmoatQKGd+8SjcV+bzvw4XaoEwminHjU83yG12+NXtQzTTQ@mail.gmail.com
| 6c417bbcc8ff98875234ca269979fc7defde58e5 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/6c417bbcc8ff98875234ca269979fc7defde58e5 | 2022-02-18 13:40:31-05:00 |
Revert "In the pg_upgrade test suite, don't write to src/test/regress."
This reverts commit bd1592e8570282b1650af6b8eede0016496daecd. It had
multiple defects.
Discussion: https://postgr.es/m/[email protected]
| ae35e1c9d74afc3b1e7572ad60781946fdf71e95 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/ae35e1c9d74afc3b1e7572ad60781946fdf71e95 | 2019-05-19 15:24:42-07:00 |
Fix error handling path in autovacuum launcher
The original code (since 00e6a16d01) was assuming aborting the
transaction in autovacuum launcher was sufficient to release all
resources, but in reality the launcher runs quite a lot of code out of
any transactions. Re-introduce individual cleanup calls to make abort
more robust.
Reported-by: Robert Haas
Discussion: https://postgr.es/m/CA+TgmobQVbz4K_+RSmiM9HeRKpy3vS5xnbkL95gSEnWijzprKQ@mail.gmail.com
| d9a622cee162775ae42aa5c1ac592760d0d777d9 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/d9a622cee162775ae42aa5c1ac592760d0d777d9 | 2017-08-15 13:35:12-03:00 |
Fix table lock levels for REINDEX INDEX CONCURRENTLY
REINDEX CONCURRENTLY locks tables with ShareUpdateExclusiveLock rather
than the ShareLock used by a plain REINDEX. However,
RangeVarCallbackForReindexIndex() was not updated for that and still
used the ShareLock only. This would lead to lock upgrades later,
leading to possible deadlocks.
Reported-by: Andres Freund <[email protected]>
Reviewed-by: Andres Freund <[email protected]>
Reviewed-by: Michael Paquier <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/20190430151735.wi52sxjvxsjvaxxt%40alap3.anarazel.de
| add85ead4ab969c1e31d64f4476c2335856f4aa9 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/add85ead4ab969c1e31d64f4476c2335856f4aa9 | 2019-05-08 14:15:01+02:00 |
Add exclusion to headercheck
src/include/common/unicode_combining_table.h is currently not meant to
be included standalone. Things could be refactored to allow it, but
that would be beyond the present purpose. So adding an exclusion here
seems best.
Discussion: https://www.postgresql.org/message-id/[email protected]
| cc25464763f0211e59a209eb50a7b7a79449051f | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/cc25464763f0211e59a209eb50a7b7a79449051f | 2020-01-24 12:23:06+01:00 |
Fix breakage of "\pset format latex".
Commit eaf746a5b unintentionally made psql's "latex" output format
inaccessible, since not only "latex" but all abbreviations of it
were considered ambiguous against "latex-longtable". Let's go
back to the longstanding behavior that all shortened versions
mean "latex", and you have to write at least "latex-" to get
"latex-longtable". This leaves the only difference from pre-v12
behavior being that "\pset format a" is considered ambiguous.
The fact that the regression tests didn't expose this is pretty bad,
but fixing it is material for a separate commit.
Discussion: https://postgr.es/m/[email protected]
| a7eece4fc9a416129aa692271972be5a30daa68c | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/a7eece4fc9a416129aa692271972be5a30daa68c | 2018-11-26 12:31:20-05:00 |
Improve the error message for an inappropriate column definition list.
The existing message about "a column definition list is only allowed for
functions returning "record"" could be given in some cases where it was
fairly confusing; in particular, a function with multiple OUT parameters
*does* return record according to pg_proc. Break it down into a couple
more cases to deliver a more on-point complaint. Per complaint from
Bruce Momjian.
Discussion: https://postgr.es/m/[email protected]
| ce90f075f0d831ca4085ba73891b7da2a2f7047e | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/ce90f075f0d831ca4085ba73891b7da2a2f7047e | 2020-09-22 10:49:11-04:00 |
Fix incorrect link in v10 release notes.
As noted by M. Justin.
Also, to keep the HEAD and REL_10 versions of release-10.sgml in sync,
back-patch the effects of c29c57890 on that file. We have a bigger
problem there though :-(
Discussion: https://postgr.es/m/CALtA7pmsQyTTD3fC2rmfUWgfivv5sCJJ84PHY0F_5t_SRc07Qg@mail.gmail.com
Discussion: https://postgr.es/m/[email protected]
| e250c8c8408a1c068285df210a7ceff68c421b3b | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/e250c8c8408a1c068285df210a7ceff68c421b3b | 2017-10-19 11:16:18-04:00 |
Prevent hard failures of standbys caused by recycled WAL segments
When a standby's WAL receiver stops reading WAL from a WAL stream, it
writes data to the current WAL segment without having priorily zero'ed
the page currently written to, which can cause the WAL reader to read
junk data from a past recycled segment and then it would try to get a
record from it. While sanity checks in place provide most of the
protection needed, in some rare circumstances, with chances increasing
when a record header crosses a page boundary, then the startup process
could fail violently on an allocation failure, as follows:
FATAL: invalid memory alloc request size XXX
This is confusing for the user and also unhelpful as this requires in
the worst case a manual restart of the instance, impacting potentially
the availability of the cluster, and this also makes WAL data look like
it is in a corrupted state.
The chances of seeing failures are higher if the connection between the
standby and its root node is unstable, causing WAL pages to be written
in the middle. A couple of approaches have been discussed, like
zero-ing new WAL pages within the WAL receiver itself but this has the
disadvantage of impacting performance of any existing instances as this
breaks the sequential writes done by the WAL receiver. This commit
deals with the problem with a more simple approach, which has no
performance impact without reducing the detection of the problem: if a
record is found with a length higher than 1GB for backends, then do not
try any allocation and report a soft failure which will force the
standby to retry reading WAL. It could be possible that the allocation
call passes and that an unnecessary amount of memory is allocated,
however follow-up checks on records would just fail, making this
allocation short-lived anyway.
This patch owes a great deal to Tsunakawa Takayuki for reporting the
failure first, and then discussing a couple of potential approaches to
the problem.
Backpatch down to 9.5, which is where palloc_extended has been
introduced.
Reported-by: Tsunakawa Takayuki
Reviewed-by: Tsunakawa Takayuki
Author: Michael Paquier
Discussion: https://postgr.es/m/0A3221C70F24FB45833433255569204D1F8B57AD@G01JPEXMBYT05
| 70b4f82a4b5cab5fc12ff876235835053e407155 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/70b4f82a4b5cab5fc12ff876235835053e407155 | 2018-06-18 10:43:27+09:00 |
Stabilize timetz test across DST transitions.
The timetz test cases I added in commit a9632830b were unintentionally
sensitive to whether or not DST is active in the PST8PDT time zone.
Thus, they'll start failing this coming weekend, as reported by
Bernhard M. Wiedemann in bug #16689. Fortunately, DST-awareness is
not significant to the purpose of these test cases, so we can just
force them all to PDT (DST hours) to preserve stability of the
results.
Back-patch to v10, as the prior patch was.
Discussion: https://postgr.es/m/[email protected]
| 4a071afbd056282746a5bc9362e87f579a56402d | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/4a071afbd056282746a5bc9362e87f579a56402d | 2020-10-29 15:28:14-04:00 |
Use American spelling for "behavior".
For consistency with the rest of the docs.
Michael Paquier
| 5b1b6bf49b44f9b26f0c9eb6d97e84973e71a0ae | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/5b1b6bf49b44f9b26f0c9eb6d97e84973e71a0ae | 2015-07-02 12:11:32+03:00 |
Remove unused function prototypes.
Cleanup for commit dee663f7.
Reported-by: Tomas Vondra <[email protected]>
Discussion: https://postgr.es/m/CA+hUKGLJ=84YT+NvhkEEDAuUtVHMfQ9i-N7k_o50JmQ6Rpj_OQ@mail.gmail.com
| 87c23d36a3bc81e57b813f13c403f74a67ff33a9 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/87c23d36a3bc81e57b813f13c403f74a67ff33a9 | 2021-01-05 11:40:03+13:00 |
Fix C++ compile failures in headers.
Avoid using "typeid" as a parameter name in header files, since that
is a C++ keyword. These cases were introduced recently, in 04fe805a1
and 586b98fdf.
Since I'm an incurable neatnik, also rename these parameters in the
underlying function definitions. That's not really necessary per
project rules, but I don't like function declarations that don't
quite agree with the underlying definitions.
Per src/tools/pginclude/cpluspluscheck.
| eaf0380eccd53df5ce7d1fed41f4ca16f4146408 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/eaf0380eccd53df5ce7d1fed41f4ca16f4146408 | 2019-01-10 14:07:01-05:00 |
Fix failure to advance content pointer in sendFileWithContent.
If sendFileWithContent were used to send a file larger than the
bbsink buffer size, this would result in corruption. The only
files that are sent via sendFileWithContent are the backup label
file, the tablespace map file, and .done files for WAL segments
included in the backup. Of these, it seems that only the
tablespace_map file can become large enough to cause a problem,
and then only if you have a lot of tablespaces. If you do have
that situation, you might end up with a corrupted
tablespace_map file, which would be bad.
My commit bef47ff85df18bf4a3a9b13bd2a54820e27f3614 introduced
this problem.
Report and patch by Antonin Houska.
Discussion: http://postgr.es/m/15764.1670528645@antos
| 45f5c81ad2bc2cd4e6a4fa0ba13b34f5c6048d44 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/45f5c81ad2bc2cd4e6a4fa0ba13b34f5c6048d44 | 2022-12-12 10:17:02-05:00 |
Make get_controlfile not leak file descriptors
When backend functions were added to expose controldata via SQL,
reading of pg_control was consolidated under src/common so that
both frontend and backend could share the same code. That move
from frontend-only to shared frontend-backend failed to recognize
the risk (and coding standards violation) of using a bare open().
In particular, it risked leaking file descriptors if transient
errors occurred while reading the file. Fix that by using
OpenTransientFile() instead in the backend case, which is
purpose-built for this type of usage.
Since there have been no complaints from the field, and an intermittent
failure low risk, no backpatch. Hard failure would of course be bad, but
in that case these functions are probably the least of your worries.
Author: Joe Conway
Reviewed-By: Michael Paquier
Reported by: Michael Paquier
Discussion: https://postgr.es/m/[email protected]
| 4598a99cf22de0dbab975d9c87ce16fd53146aca | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/4598a99cf22de0dbab975d9c87ce16fd53146aca | 2019-02-28 15:57:40-05:00 |
Fix possible logical replication crash.
Commit c3afe8cf5a1e465bd71e48e4bc717f5bfdc7a7d6 added a new
password_required option but forgot that you need database access
to check whether an arbitrary role ID is a superuser.
Report and patch by Hou Zhijie. I added a comment. Thanks to
Alexander Lakhin for devising a way to reproduce the crash.
Discussion: http://postgr.es/m/OS0PR01MB5716BFD7EC44284C89F40808948F9@OS0PR01MB5716.jpnprd01.prod.outlook.com
| e7e7da2f8d57bbe6c8fb463a9eec51486000ba2e | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/e7e7da2f8d57bbe6c8fb463a9eec51486000ba2e | 2023-04-03 13:11:00-04:00 |
Fix theoretical bug in tuplesort
This fixes a theoretical bug in tuplesort.c which, if a bounded sort was
used in combination with a byval Datum sort (tuplesort_begin_datum), when
switching the sort to a bounded heap in make_bounded_heap(), we'd call
free_sort_tuple(). The problem was that when sorting Datums of a byval
type, the tuple is NULL and free_sort_tuple() would free the memory for it
regardless of that. This would result in a crash.
Here we fix that simply by adding a check to see if the tuple is NULL
before trying to disassociate and free any memory belonging to it.
The reason this bug is only theoretical is that nowhere in the current
code base do we do tuplesort_set_bound() when performing a Datum sort.
However, let's backpatch a fix for this as if any extension uses the code
in this way then it's likely to cause problems.
Author: Ronan Dunklau
Discussion: https://postgr.es/m/CAApHDvpdoqNC5FjDb3KUTSMs5dg6f+XxH4Bg_dVcLi8UYAG3EQ@mail.gmail.com
Backpatch-through: 9.6, oldest supported version
| 41469253e970b539a4ae75226dd4f226b7b2bc8c | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/41469253e970b539a4ae75226dd4f226b7b2bc8c | 2021-07-13 12:40:16+12:00 |
Fix whitespace inconsistencies
| 1d70fb400c2c8312dac3ff19a1bb1cb5351047ce | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/1d70fb400c2c8312dac3ff19a1bb1cb5351047ce | 2023-05-15 06:27:40+02:00 |
Clean up some mess in row-security patches.
Fix unsafe coding around PG_TRY in RelationBuildRowSecurity: can't change
a variable inside PG_TRY and then use it in PG_CATCH without marking it
"volatile". In this case though it seems saner to avoid that by doing
a single assignment before entering the TRY block.
I started out just intending to fix that, but the more I looked at the
row-security code the more distressed I got. This patch also fixes
incorrect construction of the RowSecurityPolicy cache entries (there was
not sufficient care taken to copy pass-by-ref data into the cache memory
context) and a whole bunch of sloppiness around the definition and use of
pg_policy.polcmd. You can't use nulls in that column because initdb will
mark it NOT NULL --- and I see no particular reason why a null entry would
be a good idea anyway, so changing initdb's behavior is not the right
answer. The internal value of '\0' wouldn't be suitable in a "char" column
either, so after a bit of thought I settled on using '*' to represent ALL.
Chasing those changes down also revealed that somebody wasn't paying
attention to what the underlying values of ACL_UPDATE_CHR etc really were,
and there was a great deal of lackadaiscalness in the catalogs.sgml
documentation for pg_policy and pg_policies too.
This doesn't pretend to be a complete code review for the row-security
stuff, it just fixes the things that were in my face while dealing with
the bugs in RelationBuildRowSecurity.
| fd496129d160950ed681c1150ea8f627b292c511 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/fd496129d160950ed681c1150ea8f627b292c511 | 2015-01-24 16:16:22-05:00 |
Simplify post-copyright update instructions.
| 338c10b7f9157ac2fb6a785505f800f4fd919577 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/338c10b7f9157ac2fb6a785505f800f4fd919577 | 2015-01-06 11:45:17-05:00 |
Add regression tests for remote execution of extension operators/functions.
Rather than relying on other extensions to be available for installation,
let's just add some test objects to the postgres_fdw extension itself
within the regression script.
| b9f117d6cd3c79780b0c0e57068f0837f7493aa6 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/b9f117d6cd3c79780b0c0e57068f0837f7493aa6 | 2015-11-04 12:03:30-05:00 |
Suggest to the user the column they may have meant to reference.
Error messages informing the user that no such column exists can
sometimes provoke a perplexed response. This often happens due to
a subtle typo in the column name or, perhaps less likely, in the
alias name. To speed discovery of what the real issue is in such
cases, we'll now search the range table for approximate matches.
If there are one or two such matches that are good enough to think
that they might be what the user intended to type, and better than
all other approximate matches, we'll issue a hint suggesting that
the user might have intended to reference those columns.
Peter Geoghegan and Robert Haas
| e529cd4ffa605c6f14f1391af5559b3a44da0336 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/e529cd4ffa605c6f14f1391af5559b3a44da0336 | 2015-03-11 10:44:04-04:00 |
Add (void) cast in front of rmtree() call at the end of pg_upgrade
Most calls of rmtree() report an error, and the code coming from 38bfae3
has introduced one caller where this is not done. The previous behavior
was to not fail hard if any log file generated is not properly unlinked
when cleaning up the contents generated once the upgrade has completed,
so add a cast to (void) to indicate the intention behind this new code.
Per gripe from Coverity.
| 42a9e88bf6a809e6023c9d50f58cc6b9446f229d | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/42a9e88bf6a809e6023c9d50f58cc6b9446f229d | 2022-02-07 14:19:52+09:00 |
Remove an unsafe Assert, and explain join_clause_is_movable_into() better.
join_clause_is_movable_into() is approximate, in the sense that it might
sometimes return "false" when actually it would be valid to push the given
join clause down to the specified level. This is okay ... but there was
an Assert in get_joinrel_parampathinfo() that's only safe if the answers
are always exact. Comment out the Assert, and add a bunch of commentary
to clarify what's going on.
Per fuzz testing by Andreas Seltenreich. The added regression test is
a pretty silly query, but it's based on his crasher example.
Back-patch to 9.2 where the faulty logic was introduced.
| 95f4e59c3286671656aff7db45b322f14a7bb8cc | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/95f4e59c3286671656aff7db45b322f14a7bb8cc | 2015-07-28 13:20:39-04:00 |
Remove unnecessary pstrdup in fetch_table_list.
The result of TextDatumGetCString is already palloc'ed so we don't need to
allocate memory for it again. We decide not to backpatch it as there
doesn't seem to be any case where it can create a meaningful leak.
Author: Zhijie Hou
Reviewed-by: Daniel Gustafsson
Discussion: https://postgr.es/m/229fed2eb8c54c71a96ccb99e516eb12@G08CNEXMBPEKD05.g08.fujitsu.local
| c95765f47673b16ed36acbfe98e1242e3c3822a3 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/c95765f47673b16ed36acbfe98e1242e3c3822a3 | 2021-01-16 10:15:32+05:30 |
Remove bms_first_member().
This function has been semi-deprecated ever since we invented
bms_next_member(). Its habit of scribbling on the input bitmapset
isn't great, plus for sufficiently large bitmapsets it would take
O(N^2) time to complete a loop. Now we have the additional problem
that reducing the input to empty while leaving it still accessible
would violate a planned invariant. So let's just get rid of it,
after updating the few extant callers to use bms_next_member().
Patch by me; thanks to Nathan Bossart and Richard Guo for review.
Discussion: https://postgr.es/m/[email protected]
| 462bb7f12851c215dfc21a88ae0ed4bf7fcb36a3 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/462bb7f12851c215dfc21a88ae0ed4bf7fcb36a3 | 2023-03-02 11:34:29-05:00 |
Fix inconsistent parameter names between prototype and declaration
Noticed while working in this area. This code was introduced in PG15,
which is still in beta, so backpatch to there for consistency.
Backpatch-through: 15
| 80ad91ea8cfca6c817034423fc889876217c67af | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/80ad91ea8cfca6c817034423fc889876217c67af | 2022-07-15 15:26:34+12:00 |
Fix typo in ALTER SYSTEM output.
The header comment written into postgresql.auto.conf by ALTER SYSTEM
should match what initdb put there originally.
Feike Steenbergen
Discussion: https://postgr.es/m/CAK_s-G0KcKdO=0hqZkwb3s+tqZuuHwWqmF5BDsmoO9FtX75r0g@mail.gmail.com
| 6c3a7ba5bb0f960ed412b1c36e815f53347b3d79 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/6c3a7ba5bb0f960ed412b1c36e815f53347b3d79 | 2017-11-09 11:57:20-05:00 |
In PQprint(), write HTML table trailer before closing the output pipe.
This is an astonishingly ancient bit of silliness, dating AFAICS to
commit edb519b14 of 27-Jul-1996 which added the pipe close stanza in
the wrong place. It happens to be harmless given that the code above
this won't enable the pager if html3 output mode is selected. Still,
somebody might try to relax that restriction someday, and in any case
it could confuse readers and static analysis tools, so let's fix it in
HEAD.
Per bug #15541 from Pan Bian.
Discussion: https://postgr.es/m/[email protected]
| b90e6cef12662ccad8679be24cd650c6b49feb1c | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/b90e6cef12662ccad8679be24cd650c6b49feb1c | 2018-12-07 13:11:30-05:00 |
Revert "Remove reset of testtablespace from pg_regress on Windows"
This reverts commit 2b2a070, that moved the reset of path
"testtablespace" used by the regression tests as a path for tablespaces
(via --outputdir) from pg_regress to the MSVC script vcregress.pl, as
this broke the behavior added by ce5d342 to be able to safely run the
regression test suite with an administrative Windows account using a
restricted token.
Note that before 2b2a070, the code doing the reset in pg_regress.c
included a comment telling that we had better move that out to a
different place, leading to the mistake done in 2b2a070. Fix this
comment, and document instead that we had better never remove this code,
for the sake of not breaking again the behavior we expect on Windows.
Thanks to Thomas Munro and Andrew Dunstan for the discussion.
Discussion: https://postgr.es/m/[email protected]
Discussion: https://postgr.es/m/CA+hUKGLiieEzfrdWxWFE+_wnXho_F5Smx972X1wEubhS7v1q9g@mail.gmail.com
| 61be85afabba0cd85bb1bcaacbea8efa8641f564 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/61be85afabba0cd85bb1bcaacbea8efa8641f564 | 2020-07-10 17:08:13+09:00 |
doc: Add description for PGSSLCRLDIR
This was missing in the section dedicated to the supported environment
variables of libpq. Oversight in f5465fa.
Reviewed-by: Daniel Gustafsson, Kyotaro Horiguchi
Discussion: https://postgr.es/m/[email protected]
| 1e809db86b160e697a56bf47358f7733475840d3 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/1e809db86b160e697a56bf47358f7733475840d3 | 2021-06-04 09:46:15+09:00 |
Clarify some comments around SharedRecoveryState in xlog.c
SharedRecoveryState has been switched from a boolean to an enum as of
commit 4e87c48, but some comments still referred to it as a boolean.
Author: Amul Sul
Reviewed-by: Dilip Kumar, Kyotaro Horiguchi
Discussion: https://postgr.es/m/CAAJ_b97Hf+1SXnm8jySpO+Fhm+-VKFAAce1T_cupUYtnE3Nxig
| f7400823c3bd6ce03c2fe1bec5b7066bad146809 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/f7400823c3bd6ce03c2fe1bec5b7066bad146809 | 2021-02-06 10:27:55+09:00 |
Fix typos
From: Alexander Law <[email protected]>
| f0fe1c8f70bacb65513f1cbaea14eb384d346ee8 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/f0fe1c8f70bacb65513f1cbaea14eb384d346ee8 | 2016-08-16 12:00:00-04:00 |
Add pg_audit, an auditing extension
This extension provides detailed logging classes, ability to control
logging at a per-object level, and includes fully-qualified object
names for logged statements (DML and DDL) in independent fields of the
log output.
Authors: Ian Barwick, Abhijit Menon-Sen, David Steele
Reviews by: Robert Haas, Tatsuo Ishii, Sawada Masahiko, Fujii Masao,
Simon Riggs
Discussion with: Josh Berkus, Jaime Casanova, Peter Eisentraut,
David Fetter, Yeb Havinga, Alvaro Herrera, Petr Jelinek, Tom Lane,
MauMau, Bruce Momjian, Jim Nasby, Michael Paquier,
Fabrízio de Royes Mello, Neil Tiffin
| ac52bb0442f79076b14acd8ad5b696946c1053b8 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/ac52bb0442f79076b14acd8ad5b696946c1053b8 | 2015-05-14 10:36:16-04:00 |
PL/Python: Fix tests for older Python versions
Commit 8561e4840c81f7e345be2df170839846814fa004 neglected to handle
older Python versions that don't support the "with" statement. So write
the tests in a way that older versions can handle as well.
| f498704346a4ce4953fc5f837cacb545b3166ee1 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/f498704346a4ce4953fc5f837cacb545b3166ee1 | 2018-01-22 12:09:52-05:00 |
Improve error message for rejecting RETURNING clauses with dropped columns.
This error message was written with only ON SELECT rules in mind, but since
then we also made RETURNING-clause targetlists go through the same logic.
This means that you got a rather off-topic error message if you tried to
add a rule with RETURNING to a table having dropped columns. Ideally we'd
just support that, but some preliminary investigation says that it might be
a significant amount of work. Seeing that Nicklas Avén's complaint is the
first one we've gotten about this in the ten years or so that the code's
been like that, I'm unwilling to put much time into it. Instead, improve
the error report by issuing a different message for RETURNING cases, and
revise the associated comment based on this investigation.
Discussion: [email protected]
| 8d8ff5f7db7d58240fac7d5f620308c91485b253 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/8d8ff5f7db7d58240fac7d5f620308c91485b253 | 2016-02-29 19:11:38-05:00 |
Fix clashing function names between jsonb_plperl and jsonb_plperlu
This prevented them from being installed at the same time.
Author: Dagfinn Ilmari Mannsåker <[email protected]>
| 651cb9094154ca323e889269d56b94f27afaceca | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/651cb9094154ca323e889269d56b94f27afaceca | 2018-04-11 10:34:53-04:00 |
Remove unused macro
Use was removed in 25ca5a9a54923a5d6746f771c4c23e85a195bde5.
| 3c067154471100ae691d1a7b2659ee439ab7b96d | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/3c067154471100ae691d1a7b2659ee439ab7b96d | 2019-03-11 09:29:50+01:00 |
Fix determination of broken LSN in OVERWRITTEN_CONTRECORD
In commit ff9f111bce24 I mixed up inconsistent definitions of the LSN of
the first record in a page, when the previous record ends exactly at the
page boundary. The correct LSN is adjusted to skip the WAL page header;
I failed to use that when setting XLogReaderState->overwrittenRecPtr,
so at WAL replay time VerifyOverwriteContrecord would refuse to let
replay continue past that record.
Backpatch to 10. 9.6 also contains this bug, but it's no longer being
maintained.
Discussion: https://postgr.es/m/[email protected]
| 44bd3ed332d6ad3207f38b3b6deb6083f0baddf5 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/44bd3ed332d6ad3207f38b3b6deb6083f0baddf5 | 2021-11-26 11:14:27-03:00 |
Improve some comments in pg_checksums about the needed clean shutdown
It was not clear from the code why it is necessary. And we need a clean
shutdown to avoid random checksum failures caused by torn pages.
Author: Masahiko Sawada
Discussion: https://postgr.es/m/CAD21AoDum5MbAb7F=pa9dOD1W2tukuDMPzWT7NjZceNoWB_6Qw@mail.gmail.com
| 84d4de97e8d14469974eb488730a13f942aa787a | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/84d4de97e8d14469974eb488730a13f942aa787a | 2019-06-07 20:48:39+09:00 |
Add new win32 header to headerscheck and cpluspluscheck
Commit 5579388d added src/include/port/win32/netdb.h but forgot to
filter it out in the header checking scripts. Per build farm animal
crake.
| 213bd0662cef220f7a30fea348288bb8989c1883 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/213bd0662cef220f7a30fea348288bb8989c1883 | 2022-08-14 11:15:23+12:00 |
Fix bogus Name assignment in CreateStatistics
Apparently, it doesn't work to use a plain cstring as a Name datum: you
may end up having random bytes because of failing to zero the bytes
after the terminating \0, as indicated by valgrind. I introduced this
bug in 5564c1181548, so backpatch this fix to REL_10_STABLE, like that
commit.
While at it, fix a slightly misleading comment, pointed out by David
Rowley.
| 1ffb63a2a1767c3dd0c7611bed6383bd37bfbce6 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/1ffb63a2a1767c3dd0c7611bed6383bd37bfbce6 | 2018-03-06 13:17:13-03:00 |
Translation updates
Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: 3a5a71cccad5c68e01008e9e3a4f06930197a05e
| 917a68f010eb4c7e91b11ae1abe229cad722f675 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/917a68f010eb4c7e91b11ae1abe229cad722f675 | 2018-05-21 12:27:42-04:00 |
Remove duplicate word.
Amit Langote
| dc486fb96968a519cc6e0d90654b46738026ee5c | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/dc486fb96968a519cc6e0d90654b46738026ee5c | 2015-10-20 10:29:19-04:00 |
Report progress of REINDEX operations
This uses the same infrastructure that the CREATE INDEX progress
reporting uses. Add a column to pg_stat_progress_create_index to
report the OID of the index being worked on. This was not necessary
for CREATE INDEX, but it's useful for REINDEX.
Also edit the phase descriptions a bit to be more consistent with the
source code comments.
Discussion: https://www.postgresql.org/message-id/ef6a6757-c36a-9e81-123f-13b19e36b7d7%402ndquadrant.com
| 03f9e5cba0ee1633af4abe734504df50af46fbd8 | postgres | neuralsentry | 0 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/03f9e5cba0ee1633af4abe734504df50af46fbd8 | 2019-04-07 11:30:14+02:00 |
Fix syntax error in commit 20e99cddd.
Per buildfarm.
| cb9bb15783f2d6b2e66f7c18bc35e849df623dfa | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/cb9bb15783f2d6b2e66f7c18bc35e849df623dfa | 2019-07-25 14:42:02-04:00 |
Fix nbtree posting list update desc output.
We cannot use the generic array_desc approach with per-tuple nbtree
posting list update metadata because array_desc can only deal with fixed
width elements (e.g., page offset numbers). Using array_desc led to
incorrect rmgr descriptions for updates from nbtree DELETE/VACUUM WAL
records.
To fix, add specialized code to describe the update metadata as array
elements in desc output. We now iterate over the update metadata using
an approach that matches related REDO routines.
Also stop showing the updates offset number array separately in nbtree
DELETE/VACUUM desc output. It's redundant information, since the same
page offset numbers appear in the description of each individual update
element. Also make some small tweaks to the way that we format arrays
in all desc routines (not just nbtree desc routines) to make arrays a
little less verbose.
Oversight in commit 1c453cfd, which enhanced the nbtree rmgr desc
routines.
Author: Peter Geoghegan <[email protected]>
Discussion: https://postgr.es/m/CAH2-WzkbYuvwYKm-Y-72QEh6SPMQcAo9uONv+mR3bMGcu9E_Cg@mail.gmail.com
| 5d6728e588c37a4e458db9d55b308c8a3832a944 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/5d6728e588c37a4e458db9d55b308c8a3832a944 | 2023-04-10 11:15:41-07:00 |
Move isolationtester's is-blocked query into C code for speed.
Commit 4deb41381 modified isolationtester's query to see whether a
session is blocked to also check for waits occurring in GetSafeSnapshot.
However, it did that in a way that enormously increased the query's
runtime under CLOBBER_CACHE_ALWAYS, causing the buildfarm members
that use that to run about four times slower than before, and in some
cases fail entirely. To fix, push the entire logic into a dedicated
backend function. This should actually reduce the CLOBBER_CACHE_ALWAYS
runtime from what it was previously, though I've not checked that.
In passing, expose a SQL function to check for safe-snapshot blockage,
comparable to pg_blocking_pids. This is more or less free given the
infrastructure built to solve the other problem, so we might as well.
Thomas Munro
Discussion: https://postgr.es/m/[email protected]
| 511540dadf1166d80b864f63979178f324844060 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/511540dadf1166d80b864f63979178f324844060 | 2017-04-10 10:26:54-04:00 |
Redesign get_attstatsslot()/free_attstatsslot() for more safety and speed.
The mess cleaned up in commit da0759600 is clear evidence that it's a
bug hazard to expect the caller of get_attstatsslot()/free_attstatsslot()
to provide the correct type OID for the array elements in the slot.
Moreover, we weren't even getting any performance benefit from that,
since get_attstatsslot() was extracting the real type OID from the array
anyway. So we ought to get rid of that requirement; indeed, it would
make more sense for get_attstatsslot() to pass back the type OID it found,
in case the caller isn't sure what to expect, which is likely in binary-
compatible-operator cases.
Another problem with the current implementation is that if the stats array
element type is pass-by-reference, we incur a palloc/memcpy/pfree cycle
for each element. That seemed acceptable when the code was written because
we were targeting O(10) array sizes --- but these days, stats arrays are
almost always bigger than that, sometimes much bigger. We can save a
significant number of cycles by doing one palloc/memcpy/pfree of the whole
array. Indeed, in the now-probably-common case where the array is toasted,
that happens anyway so this method is basically free. (Note: although the
catcache code will inline any out-of-line toasted values, it doesn't
decompress them. At the other end of the size range, it doesn't expand
short-header datums either. In either case, DatumGetArrayTypeP would have
to make a copy. We do end up using an extra array copy step if the element
type is pass-by-value and the array length is neither small enough for a
short header nor large enough to have suffered compression. But that
seems like a very acceptable price for winning in pass-by-ref cases.)
Hence, redesign to take these insights into account. While at it,
convert to an API in which we fill a struct rather than passing a bunch
of pointers to individual output arguments. That will make it less
painful if we ever want further expansion of what get_attstatsslot can
pass back.
It's certainly arguable that this is new development and not something to
push post-feature-freeze. However, I view it as primarily bug-proofing
and therefore something that's better to have sooner not later. Since
we aren't quite at beta phase yet, let's put it in.
Discussion: https://postgr.es/m/[email protected]
| 9aab83fc5039d83e84144b7bed3fb1d62a74ae78 | postgres | neuralsentry | 1 | https://github.com/postgres/postgres | https://github.com/postgres/postgres/commit/9aab83fc5039d83e84144b7bed3fb1d62a74ae78 | 2017-05-13 15:14:39-04:00 |