commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
ACL: ACLSaveToFile() implemented.
484af7aa7a3b84067bfd5f37703baff911db608f
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/484af7aa7a3b84067bfd5f37703baff911db608f
2019-02-21 16:50:28+01:00
RESP3: SETNAME option for HELLO.
21f92e9e340f9371ee06ca87f3b16dbe0dbf0fea
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/21f92e9e340f9371ee06ca87f3b16dbe0dbf0fea
2019-02-25 16:56:58+01:00
Make redis-cli grep friendly in pubsub mode (#9013) redis-cli is grep friendly for all commands but SUBSCRIBE/PSUBSCRIBE. it is unable to process output from these commands line by line piped to another program because of output buffering. to overcome this situation I propose to flush stdout each time when it is written with reply from these commands the same way it is already done for all other commands.
77d44bb7b4f92a015aed231910d163f5571bf5f3
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/77d44bb7b4f92a015aed231910d163f5571bf5f3
2021-06-08 11:34:38+03:00
Remove useless memmove() from freeMemoryIfNeeded(). We start from the end of the pool to the initial item, zero-ing every entry we use or every ghost entry, there is nothing to memmove since to the right everything should be already set to NULL.
382991f82ee1cc213e4225ce5f28284974715def
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/382991f82ee1cc213e4225ce5f28284974715def
2016-07-11 19:18:17+02:00
Merge pull request #6893 from oranagra/api_doc_aux_save module api docs for aux_save and aux_load
f0d9a4e1a40714dc6ece98238217046950cb5d2e
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/f0d9a4e1a40714dc6ece98238217046950cb5d2e
2020-02-28 10:22:53+01:00
Change INFO CLIENTS sections to report pre-computed max/min client buffers.
ea3a20c5d05869a498d037f67f92fd05287f9428
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/ea3a20c5d05869a498d037f67f92fd05287f9428
2018-07-19 17:16:19+02:00
Merge pull request #10651 from oranagra/meir_lua_readonly_tables # Lua readonly tables The PR adds support for readonly tables on Lua to prevent security vulnerabilities: * (CVE-2022-24736) An attacker attempting to load a specially crafted Lua script can cause NULL pointer dereference which will result with a crash of the redis-server process. This issue affects all versions of Redis. * (CVE-2022-24735) By exploiting weaknesses in the Lua script execution environment, an attacker with access to Redis can inject Lua code that will execute with the (potentially higher) privileges of another Redis user. The PR is spitted into 4 commits. ### Change Lua to support readonly tables This PR modifies the Lua interpreter code to support a new flag on tables. The new flag indicating that the table is readonly and any attempt to perform any writes on such a table will result in an error. The new feature can be turned off and on using the new `lua_enablereadonlytable` Lua API. The new API can be used **only** from C code. Changes to support this feature was taken from https://luau-lang.org/ ### Change eval script to set user code on Lua registry Today, Redis wrap the user Lua code with a Lua function. For example, assuming the user code is: ``` return redis.call('ping') ``` The actual code that would have sent to the Lua interpreter was: ``` f_b3a02c833904802db9c34a3cf1292eee3246df3c() return redis.call('ping') end ``` The warped code would have been saved on the global dictionary with the following name: `f_<script sha>` (in our example `f_b3a02c833904802db9c34a3cf1292eee3246df3c`). This approach allows one user to easily override the implementation of another user code, example: ``` f_b3a02c833904802db9c34a3cf1292eee3246df3c = function() return 'hacked' end ``` Running the above code will cause `evalsha b3a02c833904802db9c34a3cf1292eee3246df3c 0` to return `hacked` although it should have returned `pong`. Another disadvantage is that Redis basically runs code on the loading (compiling) phase without been aware of it. User can do code injection like this: ``` return 1 end <run code on compling phase> function() return 1 ``` The warped code will look like this and the entire `<run code on compiling phase>` block will run outside of eval or evalsha context: ``` f_<sha>() return 1 end <run code on compling phase> function() return 1 end ``` The commits puts the user code on a special Lua table called the registry. This table is not accessible to the user so it can not be manipulated by him. Also there is no longer a need to warp the user code so there is no risk in code injection which will cause running code in the wrong context. ### Use `lua_enablereadonlytable` to protect global tables on eval and function The commit uses the new `lua_enablereadonlytable` Lua API to protect the global tables of both evals scripts and functions. For eval scripts, the implementation is easy, We simply call `lua_enablereadonlytable` on the global table to turn it into a readonly table. On functions its more complected, we want to be able to switch globals between load run and function run. To achieve this, we create a new empty table that acts as the globals table for function, we control the actual globals using metatable manipulations. Notice that even if the user gets a pointer to the original tables, all the tables are set to be readonly (using `lua_enablereadonlytable` Lua API) so he can not change them. The following better explains the solution: ``` Global table {} <- global table metatable {.__index = __real_globals__} ``` The `__real_globals__` is depends on the run context (function load or function call). Why is this solution needed and its not enough to simply switch globals? When we run in the context of function load and create our functions, our function gets the current globals that was set when they were created. Replacing the globals after the creation will not effect them. This is why this trick it mandatory. ### Protect the rest of the global API and add an allowed list to the provided API The allowed list is done by setting a metatable on the global table before initialising any library. The metatable set the `__newindex` field to a function that check the allowed list before adding the field to the table. Fields which is not on the allowed list are simply ignored. After initialisation phase is done we protect the global table and each table that might be reachable from the global table. For each table we also protect the table metatable if exists. ### Performance Performance tests was done on a private computer and its only purpose is to show that this fix is not causing any performance regression. case 1: `return redis.call('ping')` case 2: `for i=1,10000000 do redis.call('ping') end` | | Unstable eval | Unstable function | lua_readonly_tables eval | lua_readonly_tables function | |-----------------------------|---------------|-------------------|--------------------------|------------------------------| | case1 ops/sec | 235904.70 | 236406.62 | 232180.16 | 230574.14 | | case1 avg latency ms | 0.175 | 0.164 | 0.178 | 0.149 | | case2 total time in seconds | 3.373 | 3.444s | 3.268 | 3.278 | ### Breaking changes * `print` function was removed from Lua because it can potentially cause the Redis processes to get stuck (if no one reads from stdout). Users should use redis.log. An alternative is to override the `print` implementation and print the message to the log file. All the work by @MeirShpilraien, i'm just publishing it.
89772ed827209c3dca376644498a235ef3edf692
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/89772ed827209c3dca376644498a235ef3edf692
2022-04-27 12:48:51+03:00
Test: processing of master stream in slave -BUSY state. See #5297.
febe102bf6d94428779f3943aea5947893301912
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/febe102bf6d94428779f3943aea5947893301912
2018-08-31 16:43:38+02:00
redis-cli help.h updated.
70b3314141220bee2ecd73aa9e9ccd8a9a2e855f
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/70b3314141220bee2ecd73aa9e9ccd8a9a2e855f
2016-04-13 12:35:14+02:00
redis-check-rdb: initialize entry in case while is never entered.
6502947a8519e9109c6fa1575460290d92b48f38
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/6502947a8519e9109c6fa1575460290d92b48f38
2015-01-30 15:19:39+01:00
Optimized autoMemoryFreed loop
46b07cbb5c52a6a9321ab8c2134d3c6be9ddae86
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/46b07cbb5c52a6a9321ab8c2134d3c6be9ddae86
2016-05-19 12:16:14+03:00
Fix MIGRATE closing of cached socket on error. After investigating issue #3796, it was discovered that MIGRATE could call migrateCloseSocket() after the original MIGRATE c->argv was already rewritten as a DEL operation. As a result the host/port passed to migrateCloseSocket() could be anything, often a NULL pointer that gets deferenced crashing the server. Now the socket is closed at an earlier time when there is a socket error in a later stage where no retry will be performed, before we rewrite the argument vector. Moreover a check was added so that later, in the socket_err label, there is no further attempt at closing the socket if the argument was rewritten. This fix should resolve the bug reported in #3796.
f917e0da4cda8a0e6cd3242180b268706cdd2dd2
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/f917e0da4cda8a0e6cd3242180b268706cdd2dd2
2017-02-09 09:58:38+01:00
Merge pull request #6844 from oranagra/bind_config_leak Memory leak when bind config is provided twice
4aafdb185ae4840a233338988728caa8cf5624c9
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/4aafdb185ae4840a233338988728caa8cf5624c9
2020-02-06 10:33:40+01:00
Lazyfree: fix lazyfreeGetPendingObjectsCount() race reading counter.
52bc74f22150183111bc0da9cd2c29de440a50b5
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/52bc74f22150183111bc0da9cd2c29de440a50b5
2017-05-04 10:35:32+02:00
add daily github actions with libc malloc and valgrind * fix memlry leaks with diskless replica short read. * fix a few timing issues with valgrind runs * fix issue with valgrind and watchdog schedule signal about the valgrind WD issue: the stack trace test in logging.tcl, has issues with valgrind: ==28808== Can't extend stack to 0x1ffeffdb38 during signal delivery for thread 1: ==28808== too small or bad protection modes it seems to be some valgrind bug with SA_ONSTACK. SA_ONSTACK seems unneeded since WD is not recursive (SA_NODEFER was removed), also, not sure if it's even valid without a call to sigaltstack()
deee2c1ef2249120ae7db0e7523bfad4041b21a6
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/deee2c1ef2249120ae7db0e7523bfad4041b21a6
2020-05-03 09:31:50+03:00
Merge pull request #5881 from artix75/cluster_manager_join_issues Cluster Manager: create command checks for issues during "CLUSTER MEET"
5f2a256ca9b815f50f7eead442b7d9c7954ca5a7
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/5f2a256ca9b815f50f7eead442b7d9c7954ca5a7
2019-03-01 16:51:02+01:00
Corrects a couple of omissions in the modules docs
94fe98666cff0c9b1411044b8564d7aaa8253fb2
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/94fe98666cff0c9b1411044b8564d7aaa8253fb2
2016-12-05 18:34:38+02:00
RESP3: Aggregate deferred lengths functions.
57c5a766a23130cb47a801200abc2ca7cf4a2a38
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/57c5a766a23130cb47a801200abc2ca7cf4a2a38
2018-11-08 12:28:56+01:00
INFO: new memory reporting fields added.
7229af38988edee95634d5c1289ebee1a2b5fc25
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/7229af38988edee95634d5c1289ebee1a2b5fc25
2016-09-15 10:33:23+02:00
Remove argument count limit, dynamically grow argv. (#9528) Remove hard coded multi-bulk limit (was 1,048,576), new limit is INT_MAX. When client sends an m-bulk that's higher than 1024, we initially only allocate the argv array for 1024 arguments, and gradually grow that allocation as arguments are received.
93e85347136a483047e92a3a7554f428d6260b0c
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/93e85347136a483047e92a3a7554f428d6260b0c
2021-10-03 09:13:09+03:00
Redis Benchmark: display 'save' and 'appendonly' configuration
834809cbb34a3b9aa8ca2209ad09883a1a9239e2
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/834809cbb34a3b9aa8ca2209ad09883a1a9239e2
2019-02-05 19:13:50+01:00
Fix timing issue in new ACL log test (#11781) There is a timing issue in the new ACL log test: ``` *** [err]: ACL LOG aggregates similar errors together and assigns unique entry-id to new errors in tests/unit/acl.tcl Expected 1675382873989 < 1675382873989 (context: type eval line 15 cmd {assert {$timestamp_last_update_original < $timestamp_last_updated_after_update}} proc ::test) ``` Looking at the test code, we will check the `timestamp-last-updated` before and after a new ACL error occurs. Actually `WRONGPASS` errors can be executed very quickly on fast machines. For example, in the this case, the execution is completed within one millisecond. The error is easy to reproduce, if we reduce the number of the for loops, for example set to 2, and using --loop and --stop. Avoid this timing issue by adding an `after 1` before the new errors. The test was introduced in #11477.
5a3cdddd2a98a270a4e09c8ccfa44079e0f2f5be
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/5a3cdddd2a98a270a4e09c8ccfa44079e0f2f5be
2023-02-03 16:51:16+08:00
fix README about BUILD_WITH_SYSTEMD usage (#7739) BUILD_WITH_SYSTEMD is an internal variable. Users should use USE_SYSTEMD=yes.
747b4004eaf49b40a25f9b4f78f57b6328f015c7
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/747b4004eaf49b40a25f9b4f78f57b6328f015c7
2020-09-01 21:31:37+03:00
Add test for module diskless short reads
07b1abab9543205de4ed2db7bbf28d094a08960b
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/07b1abab9543205de4ed2db7bbf28d094a08960b
2019-07-21 18:18:11+03:00
Speedup INFO by counting client memory incrementally. Related to #5145. Design note: clients may change type when they turn into replicas or are moved into the Pub/Sub category and so forth. Moreover the recomputation of the bytes used is problematic for obvious reasons: it changes continuously, so as a conservative way to avoid accumulating errors, each client remembers the contribution it gave to the sum, and removes it when it is freed or before updating it with the new memory usage.
f69876280c630d49574fa094808d3a4791c5039b
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/f69876280c630d49574fa094808d3a4791c5039b
2020-04-07 12:07:09+02:00
sub-command support for ACL CAT and COMMAND LIST. redisCommand always stores fullname (#10127) Summary of changes: 1. Rename `redisCommand->name` to `redisCommand->declared_name`, it is a const char * for native commands and SDS for module commands. 2. Store the [sub]command fullname in `redisCommand->fullname` (sds). 3. List subcommands in `ACL CAT` 4. List subcommands in `COMMAND LIST` 5. `moduleUnregisterCommands` now will also free the module subcommands. 6. RM_GetCurrentCommandName returns full command name Other changes: 1. Add `addReplyErrorArity` and `addReplyErrorExpireTime` 2. Remove `getFullCommandName` function that now is useless. 3. Some cleanups about `fullname` since now it is SDS. 4. Delete `populateSingleCommand` function from server.h that is useless. 5. Added tests to cover this change. 6. Add some module unload tests and fix the leaks 7. Make error messages uniform, make sure they always contain the full command name and that it's quoted. 7. Fixes some typos see the history in #9504, fixes #10124 Co-authored-by: Oran Agra <[email protected]> Co-authored-by: guybe7 <[email protected]>
23325c135f08365d1b7d4bf4fb1c9187fc7374b9
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/23325c135f08365d1b7d4bf4fb1c9187fc7374b9
2022-01-23 16:05:06+08:00
RDMF: dictRedisObjectDestructor -> dictObjectDestructor."
5cfb792777c18778092334bf251d97b681afda84
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/5cfb792777c18778092334bf251d97b681afda84
2015-07-28 11:03:01+02:00
Merge pull request #6364 from oranagra/fix_module_aux_when Fix to module aux data rdb format for backwards compatibility with old check-rdb
86aade9a024c3582665903d0cc0c5692c6677cfd
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/86aade9a024c3582665903d0cc0c5692c6677cfd
2019-09-05 13:30:26+02:00
Use pkg-config to properly detect libssl and libcrypto libraries (#7452)
6a014af79a9cbafc0be946047f216544f116b598
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/6a014af79a9cbafc0be946047f216544f116b598
2020-07-10 01:30:09-06:00
Fix ACLAppendUserForLoading memory leak when merge error (#12296) This leak will only happen in loadServerConfigFromString, that is, when we are loading a redis.conf, and the user is wrong. Because it happens in loadServerConfigFromString, redis will exit if there is an error, so this is actually just a cleanup.
5fd9756d2e1e73371c29e981d0c5a7a91976a27c
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/5fd9756d2e1e73371c29e981d0c5a7a91976a27c
2023-06-11 09:11:16+08:00
Merge remote-tracking branch 'refs/remotes/antirez/unstable' into unstable
d0f53079e31641c860ea577f876f4361d23f53f3
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/d0f53079e31641c860ea577f876f4361d23f53f3
2016-06-30 16:34:01+05:30
Tests: fix filename reported in run_solo tests.
f6546eff452e9868569610c797765db8f56763e3
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/f6546eff452e9868569610c797765db8f56763e3
2020-11-04 17:50:31+02:00
Modules: RM_Replicate() test module: initial implementation.
45cd8e03cab6c24329c25cbb873405fe86911b5b
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/45cd8e03cab6c24329c25cbb873405fe86911b5b
2019-10-03 13:06:09+02:00
Fix assertion on loading AOF with timed out script. (#8284) If AOF file contains a long Lua script that timed out, then the `evalCommand` calls `blockingOperationEnds` which sets `server.blocked_last_cron` to 0. later on, the AOF `whileBlockedCron` function asserts that this value is not 0. The fix allows nesting call to `blockingOperationStarts` and `blockingOperationEnds`. The issue was first introduce in this commit: 9ef8d2f67 (Redis 6.2 RC1)
ecd53518700f5b2be19c18e7a19f87c9f25a7ff5
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/ecd53518700f5b2be19c18e7a19f87c9f25a7ff5
2021-01-04 13:42:17+02:00
replaced tab by spaces
6470b21f59d0c73fac2a08a477ed4ff1770ad3aa
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/6470b21f59d0c73fac2a08a477ed4ff1770ad3aa
2018-03-10 20:09:41+01:00
Merge pull request #3547 from yyoshiki41/refactor/redis-trib Refactor redis-trib.rb
25811bc9839d2af54524fea5f1dfa3042e4ce3c0
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/25811bc9839d2af54524fea5f1dfa3042e4ce3c0
2016-11-02 11:02:32+01:00
XPENDING with IDLE (#7972) Used to filter stream pending entries by their idle-time, useful for XCLAIMing entries that have not been processed for some time
ada2ac9ae2c04422f693c8d989768b97c29b8996
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/ada2ac9ae2c04422f693c8d989768b97c29b8996
2020-11-29 11:08:47+01:00
Sentinel: add link refcount to instance description
d6e1347869d22f19746b004551d43059b375868e
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/d6e1347869d22f19746b004551d43059b375868e
2015-05-11 23:49:19+02:00
Sets up fake client to select current db in RM_Call()
443f279a3a33f8047adc397bb53aad614aa35133
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/443f279a3a33f8047adc397bb53aad614aa35133
2017-03-06 14:37:10+02:00
Enable running daily CI from forks (#9771) Was impossible to run the daily CI from private forks due to "redis/redis" repo check. Let's disable that check for manual triggers.
bcb7961f12691c874c982a0a44839d2ef32e13dc
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/bcb7961f12691c874c982a0a44839d2ef32e13dc
2021-11-11 15:39:20+03:00
Threaded IO: make num of I/O threads configurable.
9814b2a5f3e91eafb21ff1fe865a161abf71045f
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/9814b2a5f3e91eafb21ff1fe865a161abf71045f
2019-03-27 18:58:45+01:00
DISCARD should not fail during OOM discard command should not fail during OOM, otherwise client MULTI state will not be cleared.
7a73b7f168eb01c4cf43ab0e0348f0f2d9922cb5
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/7a73b7f168eb01c4cf43ab0e0348f0f2d9922cb5
2019-09-21 20:58:57+03:00
Make addReplyError...() family functions able to get error codes. Now you can use: addReplyError("-MYERRORCODE some message"); If the error code is omitted, the behavior is like in the past, the generic -ERR will be used.
00a29b1a81f75dce175ac2199a7e1e9806a476dc
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/00a29b1a81f75dce175ac2199a7e1e9806a476dc
2018-02-16 16:18:01+01:00
Minor fix to print, set to str (#11934) * Minor fix to print, set to str `{commands_filename}` the extra {} actually make it become a Set, and the output print was like this: ``` Processing json files... Linking container command to subcommands... Checking all commands... Generating {'commands'}.c... All done, exiting. ``` Introduced in #11920 * more fix
2dd5c3a180a9892c339b66f76cc203f8b0f6fe5a
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/2dd5c3a180a9892c339b66f76cc203f8b0f6fe5a
2023-03-17 20:20:54+08:00
RESP3 double representation for -infinity is `,-inf\r\n`, not `-inf\r\n`
593f6656c1c6ce71eccd71496bb0e62c5f0741b7
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/593f6656c1c6ce71eccd71496bb0e62c5f0741b7
2019-07-02 14:28:48+01:00
Solaris based system rss size report. (#8138)
ec951cdc1555f544abe3c5468509e2148bdd4c3c
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/ec951cdc1555f544abe3c5468509e2148bdd4c3c
2020-12-06 13:30:29+00:00
Fix Sentinel configuration rewrite. (#8480) The `resolve-hostnames` and `announce-hostnames` parameters were not specified correctly according to the new convention introduced by 1aad55b66.
29ac9aea5de2f395960834b262b3d94f9efedbd8
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/29ac9aea5de2f395960834b262b3d94f9efedbd8
2021-02-10 18:38:10+02:00
ignore latency errors in the schema validation CI (#11958) these latency threshold errors prevent the schema validation from running.
9e15b42fda8fa622edf6a1e15cba0fc066a35407
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/9e15b42fda8fa622edf6a1e15cba0fc066a35407
2023-03-23 10:49:09+02:00
Geo: GEOPOS command and tests.
aae0a1f9cce0ced9e6aa2e76977d6db72f6b4edc
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/aae0a1f9cce0ced9e6aa2e76977d6db72f6b4edc
2015-06-29 10:47:07+02:00
ACL: reset the subcommands table on +@all / -@all. This also is a bugfix because after -@all the previously enabled subcommands would remain valid.
7fb9e2b4ce0f29fe0eeeb5f74b1310e54144f63a
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/7fb9e2b4ce0f29fe0eeeb5f74b1310e54144f63a
2019-01-28 18:27:41+01:00
Merge pull request #5746 from UmanShahzad/old-geohash-docs Remove documentation about geohash-int in deps repo.
511298578a7363637e55aafdbaf9fcd7f6cbb402
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/511298578a7363637e55aafdbaf9fcd7f6cbb402
2019-01-09 10:12:09+01:00
modules/RM_StringTruncate: correct reallocate condition
2e464bf0b110ee225757a5126331a6c25c2317f9
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/2e464bf0b110ee225757a5126331a6c25c2317f9
2016-04-06 22:49:29+08:00
HSETNX can lead coding type change even when skipped due to NX (#4615) 1. Add one key-value pair to myhash, which the length of key and value both less than hash-max-ziplist-value, for example: >hset myhash key value 2. Then execute the following command >hsetnx myhash key value1 (the length greater than hash-max-ziplist-value) 3. This will add nothing, but the code type of "myhash" changed from ziplist to dict even there are only one key-value pair in "myhash", and both of them less than hash-max-ziplist-value.
4278c45c913ccd615a7fd13c8463de79b699c4e1
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/4278c45c913ccd615a7fd13c8463de79b699c4e1
2021-06-30 17:14:11+08:00
Merge pull request #5163 from oranagra/fix_slave_buffer_test fix slave buffer test suite false positives
dfc82fca5442a7318dd713a847ec104b6285c54c
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/dfc82fca5442a7318dd713a847ec104b6285c54c
2018-07-24 10:28:48+02:00
dict.c: convert types to unsigned long where appropriate. No semantical changes since to make dict.c truly able to scale over the 32 bit table size limit, the hash function shoulds and other internals related to hash function output should be 64 bit ready.
068d3c9737b368f921808e753f6f000a12ca5ae8
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/068d3c9737b368f921808e753f6f000a12ca5ae8
2015-03-27 10:14:52+01:00
Merge pull request #5526 from valentino-redislabs/init-server-hz fix short period of server.hz being uninitialised
e93387c1d3bba0647092e96838a80910662eb415
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/e93387c1d3bba0647092e96838a80910662eb415
2018-11-06 13:00:15+01:00
Update redis-cli.c Code was adding '\n' (line 521) to the end of NIL values exlusively making csv output inconsistent. Removed '\n'
6ec5f1f78064264b9b33349858f8aa9157d4efe0
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/6ec5f1f78064264b9b33349858f8aa9157d4efe0
2015-01-25 14:01:39-05:00
Make sure execute SLAVEOF command in the right order in psync2 test. (#9316) The psync2 test has failed several times recently. In #9159 we only solved half of the problem. i.e. reordering of the replica that's already connected to the newly promoted master. Consider this scenario: 0 slaveof 2 1 slaveof 2 3 slaveof 2 4 slaveof 1 0 slaveof no one, became a new master got a new replid 2 slaveof 0, partial resync and got the new replid 3 reconnect 2, inherit the new replid 3 slaveof 4, use the new replid and got a full resync And another scenario: 1 slaveof 3 2 slaveof 4 3 slaveof 0 4 slaveof 0 4 slaveof no one, became a new master got a new replid 2 reconnect 4, inherit the new replid 2 slaveof 1, use the new replid and got a full resync So maybe we should reattach replicas in the right order. i.e. In the above example, if it would have reattached 1, 3 and 0 to the new chain formed by 4 before trying to attach 2 to 1, it would succeed. This commit break the SLAVEOF loop into two loops. (ideas from oran) First loop that uses random to decide who replicates from who. Second loop that does the actual SLAVEOF command. In the second loop, we make sure to execute it in the right order, and after each SLAVEOF, wait for it to be connected before we proceed. Co-authored-by: Oran Agra <[email protected]>
d0244bfc3df101bca8b2d94eec00feceaaff2ee0
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/d0244bfc3df101bca8b2d94eec00feceaaff2ee0
2021-08-05 16:26:09+08:00
Merge branch 'unstable' of github.com:antirez/redis into unstable
1ac30300f027c334aa044a6f579562e52f43f26b
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/1ac30300f027c334aa044a6f579562e52f43f26b
2019-10-20 09:59:23+03:00
Prevent unauthenticated client from easily consuming lots of memory (CVE-2021-32675) (#9588) This change sets a low limit for multibulk and bulk length in the protocol for unauthenticated connections, so that they can't easily cause redis to allocate massive amounts of memory by sending just a few characters on the network. The new limits are 10 arguments of 16kb each (instead of 1m of 512mb)
fba15850e5c31666e4c3560a3be7fd034fa7e2b6
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/fba15850e5c31666e4c3560a3be7fd034fa7e2b6
2021-10-04 12:10:31+03:00
Sentinel: clarify arguments of SENTINEL IS-MASTER-DOWN-BY-ADDR
b849886a0df86f17d8c2f4be35f503c58dd5d178
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/b849886a0df86f17d8c2f4be35f503c58dd5d178
2015-05-08 17:04:01+02:00
solve test timing issues in replication tests (#9121) # replication-3.tcl had a test timeout failure with valgrind on daily CI: ``` *** [err]: SLAVE can reload "lua" AUX RDB fields of duplicated scripts in tests/integration/replication-3.tcl Replication not started. ``` replication took more than 70 seconds. https://github.com/redis/redis/runs/2854037905?check_suite_focus=true on my machine it takes only about 30, but i can see how 50 seconds isn't enough. # replication.tcl loading was over too quickly in freebsd daily CI: ``` *** [err]: slave fails full sync and diskless load swapdb recovers it in tests/integration/replication.tcl Expected '0' to be equal to '1' (context: type eval line 44 cmd {assert_equal [s -1 loading] 1} proc ::start_server) ``` # rdb.tcl loading was over too quickly. increase the time loading takes, and decrease the amount of work we try to achieve in that time.
d0819d618e97c81ada5b09adffc127f332a4ce73
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/d0819d618e97c81ada5b09adffc127f332a4ce73
2021-06-22 11:10:11+03:00
fix unreported overflow in autogerenared stream IDs
b12d2f65d660b4139b322af90b6ef60ed267210b
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/b12d2f65d660b4139b322af90b6ef60ed267210b
2019-11-04 16:36:06+01:00
Update the comment
2ef8c2f6c22e27507e62bf937a5b4e9f7429fdbd
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/2ef8c2f6c22e27507e62bf937a5b4e9f7429fdbd
2017-08-18 11:27:04+08:00
Merge pull request #6989 from soloestoy/io-threads-bugfix Threaded IO: bugfix #6988 process events while blocked
681c6f21b7cfcd5d127768d1f808e1c8a976a049
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/681c6f21b7cfcd5d127768d1f808e1c8a976a049
2020-03-15 15:57:22+01:00
Introduce ReplyWithVerbatimString, ReplyWithEmptyArray, ReplyWithNullArray and ReplyWithEmptyString to redis module API
56a7c455216afee5e2d1820cf6e1dac7cf3457e6
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/56a7c455216afee5e2d1820cf6e1dac7cf3457e6
2019-10-28 08:50:25+02:00
Test: add lshuffle in the Tcl utility functions set.
967ad3643c540d3b40f64cc51b4aff6340662ffb
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/967ad3643c540d3b40f64cc51b4aff6340662ffb
2018-07-13 17:51:03+02:00
Avoid close before logging to preserve errno (#8703)
374401d7866685679acaee95ed8357287136039e
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/374401d7866685679acaee95ed8357287136039e
2021-04-15 14:11:40-04:00
Skip new redis-cli ASK test in TLS mode (#9312)
52df350fe59d73e6a1a4a5fb3c2b91d5c62f5a76
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/52df350fe59d73e6a1a4a5fb3c2b91d5c62f5a76
2021-08-03 23:19:03+03:00
Allow modules to handle RDB loading errors. This is especially needed in diskless loading, were a short read could have caused redis to exit. now the module can handle the error and return to the caller gracefully. this fixes #5326
d7d028a7a72388cf3908a5f40c8188e68a447dee
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/d7d028a7a72388cf3908a5f40c8188e68a447dee
2019-07-14 17:34:13+03:00
Sentinel command renaming: fix CONFIG SET after refactoring.
b72cecd7c89efdd5beef994723d30dba69df6947
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/b72cecd7c89efdd5beef994723d30dba69df6947
2018-06-25 17:23:32+02:00
TLS: Propagate and handle SSL_new() failures. (#7576) The connection API may create an accepted connection object in an error state, and callers are expected to check it before attempting to use it. Co-authored-by: mrpre <[email protected]>
784ceeb90d84bbc49fc2f2e2e6c7b9fae2524bd5
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/784ceeb90d84bbc49fc2f2e2e6c7b9fae2524bd5
2020-07-28 11:32:47+03:00
Fix local clients detection (#11664) Match 127.0.0.0/8 instead of just `127.0.0.1` to detect the local clients.
e1da724117bb842c383e227e57b9c45331f430db
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/e1da724117bb842c383e227e57b9c45331f430db
2023-04-04 15:45:09+08:00
master client should ignore proto_max_bulk_len in bitops (#9626)
484a1ad67e39da4d5cf07ad4687873364e1aafd4
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/484a1ad67e39da4d5cf07ad4687873364e1aafd4
2021-10-11 13:58:42+08:00
sort.c: REDIS_LIST's dontsort optimization also fix the situation "dontsort DESC" of a list
c908774b9e071cc1e4fddd8f430e13aec31f9b67
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/c908774b9e071cc1e4fddd8f430e13aec31f9b67
2015-02-02 11:29:20+08:00
Modules: RM_Call/Replicate() ability to exclude AOF/replicas.
2a81e49ddee1db6ae3c09bc8b9e1b05d430571f0
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/2a81e49ddee1db6ae3c09bc8b9e1b05d430571f0
2019-10-04 11:44:39+02:00
RESP3: Scripting RESP3 mode set/map protocol -> Lua conversion.
a1feda2388d556e6bc0c2f831e0b2f90f5f71abd
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/a1feda2388d556e6bc0c2f831e0b2f90f5f71abd
2018-11-26 16:44:00+01:00
XAUTOCLAIM: JUSTID should prevent incrementing delivery_count (#8724) To align with XCLAIM and the XAUTOCLAIM docs
2c120af61e31ead165175556a9564722d4d0149b
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/2c120af61e31ead165175556a9564722d4d0149b
2021-03-30 22:48:01+02:00
Threaded IO: handleClientsWithPendingReadsUsingThreads top comment.
3d053dbb6dea51d59709913e9c0e9f96cc1d24f8
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/3d053dbb6dea51d59709913e9c0e9f96cc1d24f8
2019-04-30 15:59:23+02:00
Add missing reply schema and coverage tests (#12079) The change in #12018 break the CI (fixed by #12083). There are quite a few sentinel commands that are missing both test coverage and also schema. PR added reply-schema to the following commands: - sentinel debug - sentinel info-cache - sentinel pendding-scripts - sentinel reset - sentinel simulate-failure Added some very basic tests for other sentinel commands, just so that they have some coverage. - sentinel help - sentinel masters - sentinel myid - sentinel sentinels - sentinel slaves These tests should be improved / replaced in a followup PR.
d659c734569be4ed32a270bac2527ccf35418c43
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/d659c734569be4ed32a270bac2527ccf35418c43
2023-04-27 14:32:14+08:00
fix multiple unblock for clientsArePaused()
e3dfd8c811e12b6b1d3f7febf732b23fdaab497b
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/e3dfd8c811e12b6b1d3f7febf732b23fdaab497b
2017-11-06 16:21:35+08:00
Threaded IO: use main thread to handle write work
8b33975944397a0522f6d05d0776d9871a7c6be0
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/8b33975944397a0522f6d05d0776d9871a7c6be0
2019-05-21 11:37:13+08:00
Merge pull request #6798 from guybe7/module_circular_block Fix memory corruption in moduleHandleBlockedClients
10afb9639a456340d4f7fa3bfb76a335cd83573c
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/10afb9639a456340d4f7fa3bfb76a335cd83573c
2020-04-02 11:17:29+02:00
Streams: fix xreadgroup crash after xgroup SETID is sent. For issue #5111.
3f8a3efe5fd968d064337276f052de187bd339b2
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/3f8a3efe5fd968d064337276f052de187bd339b2
2018-07-10 16:26:13+08:00
create-cluster fix for stop and watch commands
761fc16b4a98f3be56d1bd5079a4880bd44d37f8
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/761fc16b4a98f3be56d1bd5079a4880bd44d37f8
2015-03-24 09:44:52+13:00
update copyright year
921ca063f70b6e725ca6159a00aa02d8af1e4181
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/921ca063f70b6e725ca6159a00aa02d8af1e4181
2015-04-21 18:54:49+03:00
Propagation: flag module client as CLIENT_MULTI if needed in case of nested MULTI/EXEC
2c970532dc47e68efee55082718502e4fa591c7d
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/2c970532dc47e68efee55082718502e4fa591c7d
2019-11-22 16:20:27+08:00
Actually use the protectClient() API where needed. Related to #4804.
929c686ccee0aacc567a9892931ae46c82a2e8cd
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/929c686ccee0aacc567a9892931ae46c82a2e8cd
2018-10-09 13:18:25+02:00
Optimize set command with ex/px when updating aof.
86e9f48a0cdfb26fcf0743c91bf593414d336a01
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/86e9f48a0cdfb26fcf0743c91bf593414d336a01
2017-06-22 11:06:40+08:00
Fix deprecated tail syntax in tests (#7543)
3f2fbc4c614ff718dce7d55fd971d7ed36062c24
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/3f2fbc4c614ff718dce7d55fd971d7ed36062c24
2020-07-21 08:07:54+02:00
daily CI test with tls
1965c0099e5f1c6d0714d326cea988dff8d481c6
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/1965c0099e5f1c6d0714d326cea988dff8d481c6
2020-05-25 17:25:23+03:00
Improve testing and update flags around commands without ACL keyspec flags (#10167) This PR aims to improve the flags associated with some commands and adds various tests around these cases. Specifically, it's concerned with commands which declare keys but have no ACL flags (think `EXISTS`), the user needs either read or write permission to access this type of key. This change is primarily concerned around commands in three categories: # General keyspace commands These commands are agnostic to the underlying data outside of side channel attacks, so they are not marked as ACCESS. * TOUCH * EXISTS * TYPE * OBJECT 'all subcommands' Note that TOUCH is not a write command, it could be a side effect of either a read or a write command. # Length and cardinality commands These commands are marked as NOT marked as ACCESS since they don't return actual user strings, just metadata. * LLEN * STRLEN * SCARD * HSTRLEN # Container has member commands These commands return information about the existence or metadata about the key. These commands are NOT marked as ACCESS since the check of membership is used widely in write commands e.g. the response of HSET. * SISMEMBER * HEXISTS # Intersection cardinality commands These commands are marked as ACCESS since they process data to compute the result. * PFCOUNT * ZCOUNT * ZINTERCARD * SINTERCARD
823da54361b4da2769297b8749933e6f731d98f2
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/823da54361b4da2769297b8749933e6f731d98f2
2022-01-24 23:55:30-08:00
Geo: Pub/Sub feature removed This feature apparently is not going to be very useful, to send a GEOADD+PUBLISH combo is exactly the same. One that would make a ton of difference is the ability to subscribe to a position and a radius, and get the updates in terms of objects entering/exiting the area.
2f66550729924ccfc20c1418f498f21e0e4bdeca
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/2f66550729924ccfc20c1418f498f21e0e4bdeca
2015-06-22 13:40:26+02:00
Show subcommand full name in error log / ACL LOG (#10105) Use `getFullCommandName` to get the full name of the command. It can also get the full name of the subcommand, like "script|help". Before: ``` > SCRIPT HELP (error) NOPERM this user has no permissions to run the 'help' command or its subcommand > ACL LOG 7) "object" 8) "help" ``` After: ``` > SCRIPT HELP (error) NOPERM this user has no permissions to run the 'script|help' command > ACL LOG 7) "object" 8) "script|help" ``` Fix #10094
20c33fe6a8fce2edb3e4158bc10bde2c3740a25b
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/20c33fe6a8fce2edb3e4158bc10bde2c3740a25b
2022-01-13 02:05:14+08:00
Iterate backwards on zdiff/zinter/zunion to optimize for zslInsert (#8105) In the iterator for these functions, we'll traverse the sorted sets in a reversed way so that largest elements come first. We prefer this order because it's optimized for insertion in a skiplist, which is the destination of the elements being iterated in there functions.
4cd1fb1f40b30e08f37425e626420c580424bbf0
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/4cd1fb1f40b30e08f37425e626420c580424bbf0
2020-12-03 05:12:07-03:00
Jemalloc updated to 4.4.0. The original jemalloc source tree was modified to: 1. Remove the configure error that prevents nested builds. 2. Insert the Redis private Jemalloc API in order to allow the Redis fragmentation function to work.
27e29f4fe61d822eb23d948bcb72db76c4c887e5
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/27e29f4fe61d822eb23d948bcb72db76c4c887e5
2017-01-30 09:58:34+01:00
The seed must be static in getRandomHexChars().
e4d65e35e6a26086ec955470baff159f5947f4c3
redis
neuralsentry
1
https://github.com/redis/redis
https://github.com/redis/redis/commit/e4d65e35e6a26086ec955470baff159f5947f4c3
2015-01-22 11:10:43+01:00
TLS: Update documentation.
bb3d45a38683fc97c0b9b06ff7725fa1eca5d80c
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/bb3d45a38683fc97c0b9b06ff7725fa1eca5d80c
2020-02-05 21:13:21+02:00
Test suite: add --loop option. Very useful with --stop in order to catch heisenbugs.
3d56311f0ca077fc4661e132508ceca30e74de74
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/3d56311f0ca077fc4661e132508ceca30e74de74
2018-08-02 19:07:17+02:00
Lua debugger: redis.breakpoint() implemented.
3a04cb05eea3799a3f10ec97745c172aeebef071
redis
neuralsentry
0
https://github.com/redis/redis
https://github.com/redis/redis/commit/3a04cb05eea3799a3f10ec97745c172aeebef071
2015-11-11 10:28:35+01:00