commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
check WRONGTYPE in BITFIELD before looping on the operations.
optimization: lookup key only once, and grow at once to the max need
fixes #3259 and #3221, and also an early return if wrongtype is discovered by SET
| 5d96b7ed4ffc1b90195fd4074ead331236e8e28f | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/5d96b7ed4ffc1b90195fd4074ead331236e8e28f | 2016-05-24 23:31:36+03:00 |
fix comment error about zslDeleteRangeByScore range (#8075)
Co-authored-by: Oran Agra <[email protected]> | 0b1d89d7ae61cc9f2546cf4dbbfc5fcd7d29b518 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/0b1d89d7ae61cc9f2546cf4dbbfc5fcd7d29b518 | 2020-11-22 20:56:45+08:00 |
block: format code
| 9a65f9cd3e09468c0178782bfac0fe1c8f445a20 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/9a65f9cd3e09468c0178782bfac0fe1c8f445a20 | 2018-08-14 20:59:32+08:00 |
Merge pull request #2530 from FuGangqiang/unstable
fix sds.c | 8af99d0c09324598faf9f8e5b9aa300fc913ff3c | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/8af99d0c09324598faf9f8e5b9aa300fc913ff3c | 2015-05-04 13:00:02+02:00 |
Merge pull request #4779 from charsyam/feature/fix-streamPropagateXCLAIM
fix memory leak for streamPropagateXCLAIM | 3851d30ada437fbeedec70badc7624757f092f21 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/3851d30ada437fbeedec70badc7624757f092f21 | 2018-03-22 09:02:37+01:00 |
fix potentical memory leak in redis-cli
| 86691ccff51b0065d430836e15c81464cc691765 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/86691ccff51b0065d430836e15c81464cc691765 | 2020-03-18 09:33:52-04:00 |
sort Command lookupKeyRead and lookupKeyWrite are used on the opposite (#8283)
This is a recent problem, introduced by 7471743 (redis 6.0)
The implications are:
The sole difference between LookupKeyRead and LookupKeyWrite is for command
executed on a replica, which are not received from its master client. (for the master,
and for the master client on the replica, these two functions behave the same)!
Since SORT is a write command, this bug only implicates a writable-replica.
And these are its implications:
- SORT STORE will behave as it did before the above mentioned commit (like before
redis 6.0). on a writable-replica an already logically expired the key would have
appeared missing. (store dest key would be deleted, instead of being populated
with the data from the already logically expired key)
- SORT (the non store variant, which in theory could have been executed on
read-only-replica if it weren't for the write flag), will (in redis 6.0) have a new bug
and return the data from the already logically expired key instead of empty response. | 08ad6abd04c5aafe5471fa754000e512ae6b0f05 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/08ad6abd04c5aafe5471fa754000e512ae6b0f05 | 2021-01-04 16:28:47+08:00 |
Signal systemd readiness atfer Partial Resync
"Partial Resynchronization" is a special variant of replication success
that we have to tell systemd about if it is managing redis-server via a
Type=Notify service unit.
| dfb598cf3304818e608ceb6b5d9529a293345c4a | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/dfb598cf3304818e608ceb6b5d9529a293345c4a | 2019-12-19 21:47:24+01:00 |
redis-benchmark: Add RPUSH and RPOP tests
| 60a9418ed9adaff7844113b89fd4a4c01100f0b9 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/60a9418ed9adaff7844113b89fd4a4c01100f0b9 | 2014-11-25 12:19:58-05:00 |
Fix false positive leak reported by GCC ASAN (#9816)
Leak found by the corrupt-dump-fuzzer when using GCC ASAN, which seems
to falsely report leaks on pointers kept only on the stack when calling exit.
Instead we now use _exit on panic / assert to skip these leak checks.
Additionally, check for sanitizer warnings in the corrupt-dump-fuzzer between iterations,
so that when something is found we know which test to relate it too (and it prints reproduction command list) | 183b90a6254cbff960f912ba36896c09226d9dfe | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/183b90a6254cbff960f912ba36896c09226d9dfe | 2021-11-21 18:47:10+02:00 |
Bump freebsd-vm version to fix CI failures (#8876)
Specifically we had issues with NTP sync failure which was resolved here: https://github.com/vmactions/freebsd-vm/commit/457af7345642e154a79d219971a2d4a7c7fe2118 | 2e88b0639689a3019e27f55dfa40578847443eeb | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/2e88b0639689a3019e27f55dfa40578847443eeb | 2021-04-27 16:22:22+03:00 |
Add check for the MADV_FREE/fork arm64 Linux kernel bug (#8224)
Older arm64 Linux kernels have a bug that could lead to data corruption during
background save under the following scenario:
1) jemalloc uses MADV_FREE on a page,
2) jemalloc reuses and writes the page,
3) Redis forks the background save process, and
4) Linux performs page reclamation.
Under these conditions, Linux will reclaim the page wrongfully and the
background save process will read zeros when it tries to read the page.
The bug has been fixed in Linux with commit:
ff1712f953e27f0b0718762ec17d0adb15c9fd0b ("arm64: pgtable: Ensure dirty bit is
preserved across pte_wrprotect()")
This Commit adds an ignore-warnings config, when not found, redis will
print a warning and exit on startup (default behavior).
Co-authored-by: Oran Agra <[email protected]> | b02780c41dbc5b28d265b5cf141c03c1a7383ef9 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/b02780c41dbc5b28d265b5cf141c03c1a7383ef9 | 2021-01-07 09:06:05-06:00 |
Remove some dead code (#8605)
| 367ba4125fa08440f1e33799ccf2fedfe88129aa | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/367ba4125fa08440f1e33799ccf2fedfe88129aa | 2021-03-06 01:54:34+08:00 |
fix a bufferoverflow bug
| 0298d3ad1833c0085ebc26baeda58dc3a511de25 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/0298d3ad1833c0085ebc26baeda58dc3a511de25 | 2019-03-10 15:30:32+08:00 |
Fix EVAL timeout test failed on freebsd (#10098)
* Refactor EVAL timeout test
* since the test used r config set appendonly yes which generates a rewrite, it missed it's purpose
* Fix the bug that start_server returns before redis starts ready, which affects when multiple tests share the same dir.
* Elapsed time tracking no loner needed
Co-authored-by: Oran Agra <[email protected]> | fa600496482dcfdbf4b5af7c27b7a2eda02ac586 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/fa600496482dcfdbf4b5af7c27b7a2eda02ac586 | 2022-01-25 04:31:35+08:00 |
FLUSHDB and FLUSHALL add call forceCommandPropagation / FLUSHALL reset dirty counter to 0 if we enable save (#10691)
## FLUSHALL
We used to restore the dirty counter after `rdbSave` zeroed it if we enable save.
Otherwise FLUSHALL will not be replicated nor put into the AOF.
And then we do increment it again below.
Without that extra dirty++, when db was already empty, FLUSHALL
will not be replicated nor put into the AOF.
We now gonna replace all that dirty counter magic with a call
to forceCommandPropagation (REPL and AOF), instead of all the
messing around with the dirty counter.
Added tests to cover three part (dirty counter, REPL, AOF).
One benefit other than cleaner code is that the `rdb_changes_since_last_save` is correct in this case.
## FLUSHDB
FLUSHDB was not replicated nor put into the AOF when db was already empty.
Unlike DEL on a non-existing key, FLUSHDB always does something, and that's to call the module hook.
So basically FLUSHDB is never a NOP, and thus it should always be propagated.
Not doing that, could mean that if a module does something in that hook, and wants to
avoid issues of that hook being missing on the replica if the db is empty, it'll need to do complicated things.
So now FLUSHDB add call forceCommandPropagation, we will always propagate FLUSHDB.
Always propagating FLUSHDB seems like a safe approach that shouldn't have any drawbacks (other than looking odd)
This was mentioned in #8972
## Test section:
We actually found it while solving a race condition in the BGSAVE test (other.tcl).
It was found in extra_ci Daily Arm64 (test-libc-malloc).
```
[exception]: Executing test client: ERR Background save already in progress.
ERR Background save already in progress
```
It look like `r flushdb` trigger (schedule) a bgsave right after `waitForBgsave r` and before `r save`.
Changing flushdb to flushall, FLUSHALL will do a foreground save and then set the dirty counter to 0. | 783b210db4b79cdd1313a8196ea58fa5ad999fd1 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/783b210db4b79cdd1313a8196ea58fa5ad999fd1 | 2022-05-11 16:21:16+08:00 |
Fix TLS certificate loading for chained certificates.
This impacts client verification for chained certificates (such as Lets
Encrypt certificates). Client Verify requires the full chain in order to
properly verify the certificate.
| 151b12a80fe60e671604433876af4fd2a1f7084d | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/151b12a80fe60e671604433876af4fd2a1f7084d | 2020-05-27 08:53:29-04:00 |
Fix errors with sentinel leaked fds test. (#8482)
* Don't run test script on non-Linux.
* Verify that reported fds do indeed exist also in parent, to avoid
false negatives on some systems (namely CentOS).
Co-authored-by: Andy Pan <[email protected]> | 8c42d1257f8b6d7a1a8f30e37eef9b55785b2426 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/8c42d1257f8b6d7a1a8f30e37eef9b55785b2426 | 2021-02-11 15:25:01+02:00 |
tests: fix a typo (#9294)
Signed-off-by: Long Dai <[email protected]> | 89fdcbec8c446cfbf8befb54bf41e694c8290619 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/89fdcbec8c446cfbf8befb54bf41e694c8290619 | 2021-07-30 15:00:07+08:00 |
stop ping when client pause
| 11f2c6b115e108202bd9c3c7e94038d4afd029a8 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/11f2c6b115e108202bd9c3c7e94038d4afd029a8 | 2019-04-17 21:20:10+08:00 |
Merge pull request #5795 from zhicheng/fix-double-free-issue
fix clusterManagerGetAntiAffinityScore double free otypes | ed356c3a79e2e83e00d29914b7b4958793d68d35 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/ed356c3a79e2e83e00d29914b7b4958793d68d35 | 2019-01-22 17:28:45+01:00 |
Fix typo in deps/README.md (#7553)
| 9fc8a5efe5541a4461cd889340fda46184a4b0f2 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/9fc8a5efe5541a4461cd889340fda46184a4b0f2 | 2020-07-22 17:33:57+09:00 |
Make nodename test more consistent (#12330)
To determine when everything was stable, we couldn't just query the nodename since they aren't API visible by design. Instead, we were using a proxy piece of information which was bumping the epoch and waiting for everyone to observe that. This works for making source Node 0 and Node 1 had pinged, and Node 0 and Node 2 had pinged, but did not guarantee that Node 1 and Node 2 had pinged. Although unlikely, this can cause this failure message. To fix it I hijacked hostnames and used its validation that it has been propagated, since we know that it is stable.
I also noticed while stress testing this sometimes the test took almost 4.5 seconds to finish, which is really close to the current 5 second limit of the log check, so I bumped that up as well just to make it a bit more consistent. | 73cf0243df5063aa9167c3fc3049d54b2772e29b | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/73cf0243df5063aa9167c3fc3049d54b2772e29b | 2023-06-20 18:00:55-07:00 |
Correct proceding -> proceeding typo.
| 7560d347da90dad0ff8b13872aeb48de609d3c9f | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/7560d347da90dad0ff8b13872aeb48de609d3c9f | 2017-07-14 22:53:14+01:00 |
Merge pull request #4609 from Qinch/unstable
fix assert problem in ZIP_DECODE_PREVLENSIZE macro | 81401878de92d15f0d3529144e27a1106ad489c2 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/81401878de92d15f0d3529144e27a1106ad489c2 | 2018-01-17 10:45:11+01:00 |
PSYNC2: bugfixing pre release.
1. Master replication offset was cleared after switching configuration
to some other slave, since it was assumed you can't PSYNC after a
switch. Note the case anymore and when we successfully PSYNC we need to
have our offset untouched.
2. Secondary replication ID was not reset to "000..." pattern at
startup.
3. Master in error state replying -LOADING or other transient errors
forced the slave to discard the cached master and full resync. This is
now fixed.
4. Better logging of what's happening on failed PSYNCs.
| 5b7d42fff32ba4e8cf1f415b104bfec086023a86 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/5b7d42fff32ba4e8cf1f415b104bfec086023a86 | 2016-11-23 16:12:20+01:00 |
fix streams memory estimation, missing raxSeek
| 20e10dc7b8eeff9aa5356fd123a7c70e994e6eb4 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/20e10dc7b8eeff9aa5356fd123a7c70e994e6eb4 | 2018-06-21 17:58:29+03:00 |
New detailed key-spec flags (RO, RW, OW, RM, ACCESS, UPDATE, INSERT, DELETE) (#10122)
The new ACL key based permissions in #9974 require the key-specs (#8324) to have more
explicit flags rather than just READ and WRITE. See discussion in #10040
This PR defines two groups of flags:
One about how redis internally handles the key (mutually-exclusive).
The other is about the logical operation done from the user's point of view (3 mutually exclusive
write flags, and one read flag, all optional).
In both groups, if we can't explicitly flag something as explicit read-only, delete-only, or
insert-only, we flag it as `RW` or `UPDATE`.
here's the definition from the code:
```
/* Key-spec flags *
* -------------- */
/* The following refer what the command actually does with the value or metadata
* of the key, and not necessarily the user data or how it affects it.
* Each key-spec may must have exaclty one of these. Any operation that's not
* distinctly deletion, overwrite or read-only would be marked as RW. */
#define CMD_KEY_RO (1ULL<<0) /* Read-Only - Reads the value of the key, but
* doesn't necessarily returns it. */
#define CMD_KEY_RW (1ULL<<1) /* Read-Write - Modifies the data stored in the
* value of the key or its metadata. */
#define CMD_KEY_OW (1ULL<<2) /* Overwrite - Overwrites the data stored in
* the value of the key. */
#define CMD_KEY_RM (1ULL<<3) /* Deletes the key. */
/* The follwing refer to user data inside the value of the key, not the metadata
* like LRU, type, cardinality. It refers to the logical operation on the user's
* data (actual input strings / TTL), being used / returned / copied / changed,
* It doesn't refer to modification or returning of metadata (like type, count,
* presence of data). Any write that's not INSERT or DELETE, would be an UPADTE.
* Each key-spec may have one of the writes with or without access, or none: */
#define CMD_KEY_ACCESS (1ULL<<4) /* Returns, copies or uses the user data from
* the value of the key. */
#define CMD_KEY_UPDATE (1ULL<<5) /* Updates data to the value, new value may
* depend on the old value. */
#define CMD_KEY_INSERT (1ULL<<6) /* Adds data to the value with no chance of,
* modification or deletion of existing data. */
#define CMD_KEY_DELETE (1ULL<<7) /* Explicitly deletes some content
* from the value of the key. */
```
Unrelated changes:
- generate-command-code.py is only compatible with python3 (modified the shabang)
- generate-command-code.py print file on json parsing error
- rename `shard_channel` key-spec flag to just `channel`.
- add INCOMPLETE flag in input spec of SORT and SORT_RO | eef9c6b0ee17fe5a42cd16a812d43864868247af | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/eef9c6b0ee17fe5a42cd16a812d43864868247af | 2022-01-18 16:00:00+02:00 |
Fixed a rounding bug in geo.tcl
| b00e1891c04bd375bb7d9877397c675335f8b40c | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/b00e1891c04bd375bb7d9877397c675335f8b40c | 2019-01-15 07:26:19+00:00 |
Typo fix | f06f10e66bfe5afdb013798e02c6aec7937435a5 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/f06f10e66bfe5afdb013798e02c6aec7937435a5 | 2017-07-27 15:27:46+09:00 |
fix pingoff test race
| c480af900764cefbd60ac037d01065aad1b123d1 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/c480af900764cefbd60ac037d01065aad1b123d1 | 2020-05-31 15:51:52+03:00 |
fix missed call on freeaddrinfo
| 46f767aa19f2915cda124575958ea650ec28a12f | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/46f767aa19f2915cda124575958ea650ec28a12f | 2018-03-21 15:34:13+08:00 |
Fix typos & grammar in clusterBumpConfigEpochWithoutConsensus() comment.
| 36704d653bdb26c1e801eac904828242ad37d11c | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/36704d653bdb26c1e801eac904828242ad37d11c | 2016-01-08 12:07:52+01:00 |
Tests: add a few missing needs:debug tags. (#9806)
| 366d5101d3d3c268157860feca6696a64b77fe59 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/366d5101d3d3c268157860feca6696a64b77fe59 | 2021-11-18 23:01:56+02:00 |
CG: Add JUSTID to XCLAIM propagation to reduce CPU usage.
| 2ba9a57c9aa5a44d042338518bfd3da30dc60fc3 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/2ba9a57c9aa5a44d042338518bfd3da30dc60fc3 | 2018-03-20 11:25:49+01:00 |
Cleanup: Get rid of server.core_propagates (#11572)
1. Get rid of server.core_propagates - we can just rely on module/call nesting levels
2. Rename in_nested_call to execution_nesting and update the comment
3. Remove module_ctx_nesting (redundant, we can use execution_nesting)
4. Modify postExecutionUnitOperations according to the comment (The main purpose of this PR)
5. trackingHandlePendingKeyInvalidations: Check the nesting level inside this function
| 9c7c6924a019b902996fc4b608541f475daa649d | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/9c7c6924a019b902996fc4b608541f475daa649d | 2022-12-20 13:21:50+05:30 |
Fix RedisModule_Call tests on 32bit (#9481)
| 05e6b97bed17a5e5ba9864d4a08ef6bfa45ce222 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/05e6b97bed17a5e5ba9864d4a08ef6bfa45ce222 | 2021-09-09 23:03:02+03:00 |
Fix missing brackets around encoding variable in ZIP_DECODE_LENGTH macro
| 7c64e8896393f2fe4859a4a039e95c6ff0047fce | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/7c64e8896393f2fe4859a4a039e95c6ff0047fce | 2016-12-19 17:37:41-05:00 |
SORT memory leak fixed.
| 34e489cb8cee04b52b5cbbfe53280ad8419d0a96 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/34e489cb8cee04b52b5cbbfe53280ad8419d0a96 | 2015-09-04 10:09:32+02:00 |
HyperLogLog: fix the fix of a corruption bug.
| b2079cb508a1944841abf39715d8a2d522452467 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/b2079cb508a1944841abf39715d8a2d522452467 | 2019-07-31 10:36:23+02:00 |
Remove AOF optimization to skip expired keys.
Basically we cannot be sure that if the key is expired while writing the
AOF, the main thread will surely find the key expired. There are
possible race conditions like the moment at which the "now" is sampled,
and the fact that time may jump backward.
Think about the following:
SET a 5
EXPIRE a 1
AOF rewrite starts after about 1 second. The child process finds the key
expired, while in the main thread instead an INCR command is called
against the key "a" immediately after a fork, and the scheduler was
faster to give execution time to the main thread, so "a" is yet not
expired.
The main thread will generate an INCR a command to the AOF log that will
be appended to the rewritten AOF file, but that INCR command will target
a non existin "a" key, so a new non volatile key "a" will be created.
Two observations:
A) In theory by computing "now" before the fork, we should be sure that
if a key is expired at that time, it will be expired later when the
main thread will try to access to such key. However this does not take
into account the fact that the computer time may jump backward.
B) Technically we may still make the process safe by using a monotonic
time source.
However there were other similar related bugs, and in general the new
"vision" is that Redis persistence files should represent the memory
state without trying to be too smart: this makes the design more
consistent, bugs less likely to arise from complex interactions, and in
the end what is to fix is the Redis expire process to have less expired
keys in RAM.
Thanks to Oran Agra and Guy Benoish for writing me an email outlining
this problem, after they conducted a Redis 5 code review.
| ba92b517b8c22a4d62c583c0a6ac94fb9a0c2486 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/ba92b517b8c22a4d62c583c0a6ac94fb9a0c2486 | 2018-06-19 15:43:06+02:00 |
Fix invalid access in lpFind on corrupted listpack (#9819)
Issue found by corrupt-dump-fuzzer test with ASAN.
The problem was that lpSkip and lpGetWithSize could read the next listpack entry without validating that it's in range.
Similarly even the memcmp in lpFind could do that and possibly crash on segfault and now they'll crash on assert first.
The naive fix of using lpAssertValidEntry every time, resulted in 30% degradation in the lpFind benchmark of the unit test.
The final fix with the condition at the bottom has no performance implications. | f07dedf73facfed5044efaf2a7a780581bf73ffa | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/f07dedf73facfed5044efaf2a7a780581bf73ffa | 2021-11-22 15:30:00+02:00 |
Adds pub/sub channel patterns to ACL (#7993)
Fixes #7923.
This PR appropriates the special `&` symbol (because `@` and `*` are taken),
followed by a literal value or pattern for describing the Pub/Sub patterns that
an ACL user can interact with. It is similar to the existing key patterns
mechanism in function (additive) and implementation (copy-pasta). It also adds
the allchannels and resetchannels ACL keywords, naturally.
The default user is given allchannels permissions, whereas new users get
whatever is defined by the acl-pubsub-default configuration directive. For
backward compatibility in 6.2, the default of this directive is allchannels but
this is likely to be changed to resetchannels in the next major version for
stronger default security settings.
Unless allchannels is set for the user, channel access permissions are checked
as follows :
* Calls to both PUBLISH and SUBSCRIBE will fail unless a pattern matching the
argumentative channel name(s) exists for the user.
* Calls to PSUBSCRIBE will fail unless the pattern(s) provided as an argument
literally exist(s) in the user's list.
Such failures are logged to the ACL log.
Runtime changes to channel permissions for a user with existing subscribing
clients cause said clients to disconnect unless the new permissions permit the
connections to continue. Note, however, that PSUBSCRIBErs' patterns are matched
literally, so given the change bar:* -> b*, pattern subscribers to bar:* will be
disconnected.
Notes/questions:
* UNSUBSCRIBE, PUNSUBSCRIBE and PUBSUB remain unprotected due to lack of reasons
for touching them.
| c1b1e8c329567e90ec0edcb8c176e9f58a7d7435 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/c1b1e8c329567e90ec0edcb8c176e9f58a7d7435 | 2020-12-01 14:21:39+02:00 |
RM_ZsetRem: Delete key if empty (#8453)
Without this fix, RM_ZsetRem can leave empty sorted sets which are
not allowed to exist.
Removing from a sorted set while iterating seems to work (while
inserting causes failed assetions). RM_ZsetRangeEndReached is
modified to return 1 if the key doesn't exist, to terminate
iteration when the last element has been removed. | aea6e71ef82701e07177744e600e1ef20d60b7d0 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/aea6e71ef82701e07177744e600e1ef20d60b7d0 | 2021-02-05 18:54:01+01:00 |
fix string to double conversion, stopped parsing on \0 even if the string has more data.
getLongLongFromObject calls string2ll which has this line:
/* Return if not all bytes were used. */
so if you pass an sds with 3 characters "1\01" it will fail.
but getLongDoubleFromObject calls strtold, and considers it ok if eptr[0]==`\0`
i.e. if the end of the string found by strtold ends with null terminator
127.0.0.1:6379> set a 1
OK
127.0.0.1:6379> setrange a 2 2
(integer) 3
127.0.0.1:6379> get a
"1\x002"
127.0.0.1:6379> incrbyfloat a 2
"3"
127.0.0.1:6379> get a
"3"
| adf2701cc95085a4a9980da7b7367b1836c5a0f2 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/adf2701cc95085a4a9980da7b7367b1836c5a0f2 | 2017-11-23 16:42:15+02:00 |
Fix redis-cli cluster add-node race in cli.tcl (#11349)
There is a race condition in the test:
```
*** [err]: redis-cli --cluster add-node with cluster-port in tests/unit/cluster/cli.tcl
Expected '5' to be equal to '4' {assert_equal 5 [CI 0 cluster_known_nodes]} proc ::test)
```
When using cli to add node, there can potentially be a race condition
in which all nodes presenting cluster state o.k even though the added
node did not yet meet all cluster nodes.
This comment and the fix were taken from #11221. Also apply it in several
other similar places. | a549b78c48121c698c84536d25404a23f01c167d | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/a549b78c48121c698c84536d25404a23f01c167d | 2022-10-03 14:21:41+08:00 |
Fix integer overflow in STRALGO LCS (CVE-2021-32625) (#9011)
An integer overflow bug in Redis version 6.0 or newer can be exploited using the
STRALGO LCS command to corrupt the heap and potentially result with remote code
execution. This is a result of an incomplete fix by CVE-2021-29477. | 1ddecf1958924b178b76a31d989ef1e05af81964 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/1ddecf1958924b178b76a31d989ef1e05af81964 | 2021-06-01 09:12:45+03:00 |
Fixes segfault on calling trackingGetTotalKeys
... with CSC disabled
| 8a44b2cc7ee15fedbacceced5d4a64d1b2a917c5 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/8a44b2cc7ee15fedbacceced5d4a64d1b2a917c5 | 2020-02-14 17:13:58+02:00 |
Prevent LCS from allocating temp memory over proto-max-bulk-len (#9817)
LCS can allocate immense amount of memory (sizes of two inputs multiplied by each other).
In the past this caused some possible security issues due to overflows, which we solved
and also added use of `trymalloc` to return "Insufficient memory" instead of OOM panic zmalloc.
But in case overcommit is enabled, it could be that we won't get the OOM panic, and zmalloc
will succeed, and then we can get OOM killed by the kernel.
The solution here is to prevent LCS from allocating transient memory that's bigger than
`proto-max-bulk-len` config.
This config is not directly related to transient memory, but using a hard coded value ad well as
introducing a specific config seems wrong.
This comes to solve an error in the corrupt-dump-fuzzer test that started in the daily CI see #9799 | 14176484697dc96df62c76630eef2b97a89bb8d0 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/14176484697dc96df62c76630eef2b97a89bb8d0 | 2021-11-21 14:30:20+02:00 |
Sanitize dump payload: fuzz tester and fixes for segfaults and leaks it exposed
The test creates keys with various encodings, DUMP them, corrupt the payload
and RESTORES it.
It utilizes the recently added use-exit-on-panic config to distinguish between
asserts and segfaults.
If the restore succeeds, it runs random commands on the key to attempt to
trigger a crash.
It runs in two modes, one with deep sanitation enabled and one without.
In the first one we don't expect any assertions or segfaults, in the second one
we expect assertions, but no segfaults.
We also check for leaks and invalid reads using valgrind, and if we find them
we print the commands that lead to that issue.
Changes in the code (other than the test):
- Replace a few NPD (null pointer deference) flows and division by zero with an
assertion, so that it doesn't fail the test. (since we set the server to use
`exit` rather than `abort` on assertion).
- Fix quite a lot of flows in rdb.c that could have lead to memory leaks in
RESTORE command (since it now responds with an error rather than panic)
- Add a DEBUG flag for SET-SKIP-CHECKSUM-VALIDATION so that the test don't need
to bother with faking a valid checksum
- Remove a pile of code in serverLogObjectDebugInfo which is actually unsafe to
run in the crash report (see comments in the code)
- fix a missing boundary check in lzf_decompress
test suite infra improvements:
- be able to run valgrind checks before the process terminates
- rotate log files when restarting servers
| c31055db617a7fedb20c28c245ddad8ed2b11931 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/c31055db617a7fedb20c28c245ddad8ed2b11931 | 2020-08-14 16:05:34+03:00 |
fixed stop condition in RM_ZsetRangeNext and RM_ZsetRangePrev
| 7f9b9512b877af96ded1c9758c23c075bab36f8d | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/7f9b9512b877af96ded1c9758c23c075bab36f8d | 2016-12-15 00:07:20+02:00 |
Ziplist: insertion bug under particular conditions fixed.
Ziplists had a bug that was discovered while investigating a different
issue, resulting in a corrupted ziplist representation, and a likely
segmentation foult and/or data corruption of the last element of the
ziplist, once the ziplist is accessed again.
The bug happens when a specific set of insertions / deletions is
performed so that an entry is encoded to have a "prevlen" field (the
length of the previous entry) of 5 bytes but with a count that could be
encoded in a "prevlen" field of a since byte. This could happen when the
"cascading update" process called by ziplistInsert()/ziplistDelete() in
certain contitious forces the prevlen to be bigger than necessary in
order to avoid too much data moving around.
Once such an entry is generated, inserting a very small entry
immediately before it will result in a resizing of the ziplist for a
count smaller than the current ziplist length (which is a violation,
inserting code expects the ziplist to get bigger actually). So an FF
byte is inserted in a misplaced position. Moreover a realloc() is
performed with a count smaller than the ziplist current length so the
final bytes could be trashed as well.
SECURITY IMPLICATIONS:
Currently it looks like an attacker can only crash a Redis server by
providing specifically choosen commands. However a FF byte is written
and there are other memory operations that depend on a wrong count, so
even if it is not immediately apparent how to mount an attack in order
to execute code remotely, it is not impossible at all that this could be
done. Attacks always get better... and we did not spent enough time in
order to think how to exploit this issue, but security researchers
or malicious attackers could.
| c495d095ae495ea5253443ee4562aaa30681a854 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/c495d095ae495ea5253443ee4562aaa30681a854 | 2017-01-30 16:34:08+01:00 |
Fix ziplist and listpack overflows and truncations (CVE-2021-32627, CVE-2021-32628) (#9589)
- fix possible heap corruption in ziplist and listpack resulting by trying to
allocate more than the maximum size of 4GB.
- prevent ziplist (hash and zset) from reaching size of above 1GB, will be
converted to HT encoding, that's not a useful size.
- prevent listpack (stream) from reaching size of above 1GB.
- XADD will start a new listpack if the new record may cause the previous
listpack to grow over 1GB.
- XADD will respond with an error if a single stream record is over 1GB
- List type (ziplist in quicklist) was truncating strings that were over 4GB,
now it'll respond with an error.
Co-authored-by: sundb <[email protected]> | c5e6a6204c4cf57f85e7c83a9b4e99f1a7204fd2 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/c5e6a6204c4cf57f85e7c83a9b4e99f1a7204fd2 | 2021-10-04 12:11:02+03:00 |
String pattern matching had exponential time complexity on pathological patterns (CVE-2022-36021) (#11858)
Authenticated users can use string matching commands with a
specially crafted pattern to trigger a denial-of-service attack on Redis,
causing it to hang and consume 100% CPU time.
Co-authored-by: Tom Levy <[email protected]> | dcbfcb916ca1a269b3feef86ee86835294758f84 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/dcbfcb916ca1a269b3feef86ee86835294758f84 | 2023-02-28 15:15:26+02:00 |
Fix crash when overcommit_memory is inaccessible (#10848)
When `/proc/sys/vm/overcommit_memory` is inaccessible, fp is NULL.
`checkOvercommit` will return -1 without setting err_msg, and then
the err_msg is used to print the log, crash the server.
Set the err_msg variables to Null when declaring it, seems safer.
And the overcommit_memory error log will print two "WARNING",
like `WARNING WARNING overcommit_memory is set to 0!`, this PR
also removes the second WARNING in `checkOvercommit`.
Reported in #10846. Fixes #10846. Introduced in #10636 (7.0.1) | 62ac1ab007b9ba25588671fdefd0025028030504 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/62ac1ab007b9ba25588671fdefd0025028030504 | 2022-06-12 03:27:44+08:00 |
Cluster Manager: fixed infinite loop in rebalance (Issue #4941).
| 4bce88b11fdf68ab754cf9125ffaac02c6428ff5 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/4bce88b11fdf68ab754cf9125ffaac02c6428ff5 | 2018-05-28 17:23:42+02:00 |
Adds isolated netstats for replication. (#10062)
The amount of `server.stat_net_output_bytes/server.stat_net_input_bytes`
is actually the sum of replication flow and users' data flow.
It may cause confusions like this:
"Why does my server get such a large output_bytes while I am doing nothing? ".
After discussions and revisions, now here is the change about what this
PR brings (final version before merge):
- 2 server variables to count the network bytes during replication,
including fullsync and propagate bytes.
- `server.stat_net_repl_output_bytes`/`server.stat_net_repl_input_bytes`
- 3 info fields to print the input and output of repl bytes and instantaneous
value of total repl bytes.
- `total_net_repl_input_bytes` / `total_net_repl_output_bytes`
- `instantaneous_repl_total_kbps`
- 1 new API `rioCheckType()` to check the type of rio. So we can use this
to distinguish between diskless and diskbased replication
- 2 new counting items to keep network statistics consistent between master
and slave
- rdb portion during diskless replica. in `rdbLoadProgressCallback()`
- first line of the full sync payload. in `readSyncBulkPayload()`
Co-authored-by: Oran Agra <[email protected]> | bb1de082eac26d5242733eb0b40959bd9de2e15b | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/bb1de082eac26d5242733eb0b40959bd9de2e15b | 2022-05-31 13:07:33+08:00 |
Fix Integer overflow issue with intsets (CVE-2021-32687) (#9586)
The vulnerability involves changing the default set-max-intset-entries
configuration parameter to a very large value and constructing specially
crafted commands to manipulate sets | 7cb89a5a1cc8ee0b003a36b2eba42573c09c45f9 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/7cb89a5a1cc8ee0b003a36b2eba42573c09c45f9 | 2021-10-04 12:09:25+03:00 |
Fix edge-case when a module client is unblocked (#8618)
Scenario:
1. A module client is blocked on keys with a timeout
2. Shortly before the timeout expires, the key is being populated and signaled
as ready
3. Redis calls moduleTryServeClientBlockedOnKey (which replies to client) and
then moduleUnblockClient
4. moduleUnblockClient doesn't really unblock the client, it writes to
server.module_blocked_pipe and only marks the BC as unblocked.
5. beforeSleep kics in, by this time the client still exists and techincally
timed-out. beforeSleep replies to the timeout client (double reply) and
only then moduleHandleBlockedClients is called, reading from module_blocked_pipe
and calling unblockClient
The solution is similar to what was done in moduleTryServeClientBlockedOnKey: we
should avoid re-processing an already-unblocked client | e58118cda6cacb5a845a9cf8eda45074470e31b2 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/e58118cda6cacb5a845a9cf8eda45074470e31b2 | 2021-03-08 18:00:19+01:00 |
Streams: free lp if all elements are deleted
| c9324f81a209c49c795d41ab2af8cb06b72d87c9 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/c9324f81a209c49c795d41ab2af8cb06b72d87c9 | 2018-07-16 15:57:41+08:00 |
Client side caching: config option for table fill rate.
| 32efd9adf8d9ea2005495433f77fdbd4fac09c3a | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/32efd9adf8d9ea2005495433f77fdbd4fac09c3a | 2019-07-24 11:35:01+02:00 |
Fix preprocessor if/else chain broken in order to fix #3927.
| f47607af0242c31a113e6ff9c0a884acec036757 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/f47607af0242c31a113e6ff9c0a884acec036757 | 2017-04-11 16:54:27+02:00 |
ACL: check patterns instead of passwords in ACLCheckCommandPerm
| 8fc0079366fcf7c75cbfd4864c448ca9aae5c835 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/8fc0079366fcf7c75cbfd4864c448ca9aae5c835 | 2019-01-25 19:06:18+08:00 |
Another typo in protected mode error message.
| 1e7a8f8221aa37bf2d6454e833b005e2bb9c6465 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/1e7a8f8221aa37bf2d6454e833b005e2bb9c6465 | 2016-01-07 22:42:43+01:00 |
Implement Multi Part AOF mechanism to avoid AOFRW overheads. (#9788)
Implement Multi-Part AOF mechanism to avoid overheads during AOFRW.
Introducing a folder with multiple AOF files tracked by a manifest file.
The main issues with the the original AOFRW mechanism are:
* buffering of commands that are processed during rewrite (consuming a lot of RAM)
* freezes of the main process when the AOFRW completes to drain the remaining part of the buffer and fsync it.
* double disk IO for the data that arrives during AOFRW (had to be written to both the old and new AOF files)
The main modifications of this PR:
1. Remove the AOF rewrite buffer and related code.
2. Divide the AOF into multiple files, they are classified as two types, one is the the `BASE` type,
it represents the full amount of data (Maybe AOF or RDB format) after each AOFRW, there is only
one `BASE` file at most. The second is `INCR` type, may have more than one. They represent the
incremental commands since the last AOFRW.
3. Use a AOF manifest file to record and manage these AOF files mentioned above.
4. The original configuration of `appendfilename` will be the base part of the new file name, for example:
`appendonly.aof.1.base.rdb` and `appendonly.aof.2.incr.aof`
5. Add manifest-related TCL tests, and modified some existing tests that depend on the `appendfilename`
6. Remove the `aof_rewrite_buffer_length` field in info.
7. Add `aof-disable-auto-gc` configuration. By default we're automatically deleting HISTORY type AOFs.
It also gives users the opportunity to preserve the history AOFs. just for testing use now.
8. Add AOFRW limiting measure. When the AOFRW failures reaches the threshold (3 times now),
we will delay the execution of the next AOFRW by 1 minute. If the next AOFRW also fails, it will be
delayed by 2 minutes. The next is 4, 8, 16, the maximum delay is 60 minutes (1 hour). During the limit
period, we can still use the 'bgrewriteaof' command to execute AOFRW immediately.
9. Support upgrade (load) data from old version redis.
10. Add `appenddirname` configuration, as the directory name of the append only files. All AOF files and
manifest file will be placed in this directory.
11. Only the last AOF file (BASE or INCR) can be truncated. Otherwise redis will exit even if
`aof-load-truncated` is enabled.
Co-authored-by: Oran Agra <[email protected]> | 87789fae0b767e47fef78ee994434554f2bf2f31 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/87789fae0b767e47fef78ee994434554f2bf2f31 | 2022-01-04 01:14:13+08:00 |
MULTI: OOM err if cannot free enough memory in MULTI/EXEC context
| e2de7e75248a928280d6c739e9020d8c8adc1c0f | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/e2de7e75248a928280d6c739e9020d8c8adc1c0f | 2018-10-17 16:40:45+08:00 |
Merge pull request #7264 from oranagra/test_for_7205
add regression test for the race in #7205 | 08d00dad5297440ea0680faf236a03d7390e9e51 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/08d00dad5297440ea0680faf236a03d7390e9e51 | 2020-05-17 17:59:14+02:00 |
handleClientsBlockedOnKeys() refactoring.
| a092f20d87f6e435c5b68b8e217ae0d54dd12715 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/a092f20d87f6e435c5b68b8e217ae0d54dd12715 | 2019-09-06 12:24:26+02:00 |
Streams: export iteration API.
| 01ea018c4080e24b00d36e1cbf36c4d98b82ff40 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/01ea018c4080e24b00d36e1cbf36c4d98b82ff40 | 2017-09-15 12:17:25+02:00 |
Use chi-square for random distributivity verification in test (#8709)
Problem:
Currently, when performing random distribution verification, we determine
the probability of each element occurring in the sum, but the probability is
only an estimate, these tests had rare sporadic failures, and we cannot verify
what the probability of failure will be.
Solution:
Using the chi-square distribution instead of the original random distribution
validation makes the test more reasonable and easier to find problems. | 569a3f4548cc525aac8bd246da213eb48a17f0e1 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/569a3f4548cc525aac8bd246da213eb48a17f0e1 | 2021-04-01 13:20:15+08:00 |
Minor improvements to module blocked on keys (#7903)
- Clarify some documentation comments
- Make sure blocked-on-keys client privdata is accessible
from withing the timeout callback
- Handle blocked clients in beforeSleep - In case a key
becomes "ready" outside of processCommand
See #7879 #7880 | addf47dcacec596eb7f6e1500846331d3e13fff4 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/addf47dcacec596eb7f6e1500846331d3e13fff4 | 2020-10-12 16:13:38+02:00 |
Fix integer overflow in STRALGO LCS (CVE-2021-29477)
An integer overflow bug in Redis version 6.0 or newer could be exploited using
the STRALGO LCS command to corrupt the heap and potentially result with remote
code execution.
| f0c5f920d0f88bd8aa376a2c05af4902789d1ef9 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/f0c5f920d0f88bd8aa376a2c05af4902789d1ef9 | 2021-05-03 08:32:31+03:00 |
Merge pull request #4154 from liangsijian/unstable
Fix lua ldb command log | 7c3c472b5e5861787055c74b189e6a8b590e9e81 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/7c3c472b5e5861787055c74b189e6a8b590e9e81 | 2017-07-24 14:11:10+02:00 |
Add test verifying PUBSUB NUMPAT behavior (#9209)
| 8b8f05c86c1f1f002caa1f4e1877020389f167e4 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/8b8f05c86c1f1f002caa1f4e1877020389f167e4 | 2021-09-03 15:52:39-07:00 |
Cluster Manager: 'backup' command
| fb020ab090f6059bc8dbcfae3d333f9997fba5c3 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/fb020ab090f6059bc8dbcfae3d333f9997fba5c3 | 2019-02-15 20:37:18+01:00 |
Normalize the style of help information with other documentation (#10965)
| 8221d481656e3bc109d85dd6523e723d63024ae6 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/8221d481656e3bc109d85dd6523e723d63024ae6 | 2022-07-12 12:56:02-04:00 |
Add missing calls to raxStop (#7532)
Since the dynamic allocations in raxIterator are only used for deep walks, memory
leak due to missing call to raxStop can only happen for rax with key names longer
than 32 bytes.
Out of all the missing calls, the only ones that may lead to a leak are the rax
for consumer groups and consumers, and these were only in AOFRW and rdbSave, which
normally only happen in fork or at shutdown. | 4e8f2d6881a38397bfbf0d7d161959163a5f6e88 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/4e8f2d6881a38397bfbf0d7d161959163a5f6e88 | 2020-07-21 01:13:05-04:00 |
Cluster: ability to prevent slaves from failing over their masters.
This commit, in some parts derived from PR #3041 which is no longer
possible to merge (because the user deleted the original branch),
implements the ability of slaves to have a special configuration
preventing that they try to start a failover when the master is failing.
There are multiple reasons for wanting this, and the feautre was
requested in issue #3021 time ago.
The differences between this patch and the original PR are the
following:
1. The flag is saved/loaded on the nodes configuration.
2. The 'myself' node is now flag-aware, the flag is updated as needed
when the configuration is changed via CONFIG SET.
3. The flag name uses NOFAILOVER instead of NO_FAILOVER to be consistent
with existing NOADDR.
4. The redis.conf documentation was rewritten.
Thanks to @deep011 for the original patch.
| 432bf4770e8f2c11e63477620e4765abfbdf91f5 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/432bf4770e8f2c11e63477620e4765abfbdf91f5 | 2018-03-14 13:46:36+01:00 |
Stabilize bgsave test that sometimes fails with valgrind (#7559)
on ci.redis.io the test fails a lot, reporting that bgsave didn't end.
increaseing the timeout we wait for that bgsave to get aborted.
in addition to that, i also verify that it indeed got aborted by
checking that the save counter wasn't reset.
add another test to verify that a successful bgsave indeed resets the
change counter. | 8a57969fd75db01b881d438200911d95bdead293 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/8a57969fd75db01b881d438200911d95bdead293 | 2020-07-23 13:06:24+03:00 |
Use fchmod to update command history file. (#9447)
This is considered a safer approach as it prevents a race condition that
could lead to chmod executed on a different file.
Not a major risk, but CodeQL alerted this so it makes sense to fix. | c9931ddba53f43c291cb61b6976a91496976e2fd | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/c9931ddba53f43c291cb61b6976a91496976e2fd | 2021-09-02 10:00:00+03:00 |
Remove Duplicate Processing
| c76b9b644c11f8b7284755664670d9baa64f1907 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/c76b9b644c11f8b7284755664670d9baa64f1907 | 2016-10-13 15:17:07+09:00 |
wait command optimization (#7333)
Client that issued WAIT last will most likely have the highest replication offset, so imagine a probably common case where all clients are waiting for the same number of replicas. we prefer the loop to start from the last client (one waiting for the highest offset), so that the optimization in the function will call replicationCountAcksByOffset for each client until it found a good one, and stop calling it for the rest of the clients.
the way the loop was implemented would mean that in such case it is likely to call replicationCountAcksByOffset for all clients.
Note: the change from > to >= is not directly related to the above.
Co-authored-by: 曹正斌 <[email protected]> | d10b2f3173ebfcc673d4ec36efef512802e3a535 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/d10b2f3173ebfcc673d4ec36efef512802e3a535 | 2020-08-13 19:30:51+08:00 |
Fixed a bug in the emptyDb() new implementation.
| 535969679673f8b3cb904eef3de0f8104cacf072 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/535969679673f8b3cb904eef3de0f8104cacf072 | 2015-09-28 11:07:24+02:00 |
fix: fix benchmark cannot exit when NOAUTH err happens
| ad223e204222dca7758eb540a455bca93e62b861 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/ad223e204222dca7758eb540a455bca93e62b861 | 2019-03-13 20:46:33+08:00 |
Lua debugger: redis-cli error when --ldb is without --eval.
Otherwise the result is a messed CLI without prompt.
Thanks to Itamar Haber for reporting this issue.
| 6de2306add95460a488d76e57b5cf2b5db17d5da | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/6de2306add95460a488d76e57b5cf2b5db17d5da | 2015-11-16 12:07:08+01:00 |
Make tcp-keepalive default to 300 in internal conf.
We already changed the default in the redis.conf template, but I forgot
to change the internal config as well.
| b99ad1bd808fcfa5f57301a65c875d8c16d7cf71 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/b99ad1bd808fcfa5f57301a65c875d8c16d7cf71 | 2016-07-04 12:08:37+02:00 |
make sort/ro commands validate external keys access patterns (#10106) (#10340)
Currently the sort and sort_ro can access external keys via `GET` and `BY`
in order to make sure the user cannot violate the authorization ACL
rules, the decision is to reject external keys access patterns unless ACL allows
SORT full access to all keys.
I.e. for backwards compatibility, SORT with GET/BY keeps working, but
if ACL has restrictions to certain keys, these features get permission denied.
### Implemented solution
We have discussed several potential solutions and decided to only allow the GET and BY
arguments when the user has all key permissions with the SORT command. The reasons
being that SORT with GET or BY is problematic anyway, for instance it is not supported in
cluster mode since it doesn't declare keys, and we're not sure the combination of that feature
with ACL key restriction is really required.
**HOWEVER** If in the fullness of time we will identify a real need for fine grain access
support for SORT, we would implement the complete solution which is the alternative
described below.
### Alternative (Completion solution):
Check sort ACL rules after executing it and before committing output (either via store or
to COB). it would require making several changes to the sort command itself. and would
potentially cause performance degradation since we will have to collect all the get keys
instead of just applying them to a temp array and then scan the access keys against the
ACL selectors. This solution can include an optimization to avoid the overheads of collecting
the key names, in case the ACL rules grant SORT full key-access, or if the ACL key pattern
literal matches the one used in GET/BY. It would also mean that authorization would be
O(nlogn) since we will have to complete most of the command execution before we can
perform verification
Co-authored-by: Madelyn Olson <[email protected]>
Co-authored-by: Oran Agra <[email protected]> | 1078e30c5ff0e13e18192faada8efe3e97299db3 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/1078e30c5ff0e13e18192faada8efe3e97299db3 | 2022-03-15 17:14:53+02:00 |
Streams: basic XADD tests.
| 7a41b402c1a5caae30dcd234d3d01c7f76ca5757 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/7a41b402c1a5caae30dcd234d3d01c7f76ca5757 | 2017-09-15 15:54:18+02:00 |
Add expire.c and evict.c.
| 4a140d320f7a8e1a63f9c3ca588f61f21838f3ac | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/4a140d320f7a8e1a63f9c3ca588f61f21838f3ac | 2016-07-06 15:28:18+02:00 |
improve malloc efficiency: reduce call times of zrealloc (#10533)
* improve malloc efficiency: reduce call times of zrealloc
Co-authored-by: Madelyn Olson <[email protected]> | ee17e7af8da0c6e482bc24ad1e2197d94cba1e1f | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/ee17e7af8da0c6e482bc24ad1e2197d94cba1e1f | 2022-04-10 10:52:36+08:00 |
fix memory leak in processInlineBuffer error handling code (#8295)
This code path is normally executed only when v6.0 and above replicates from v2.4 | cfcd0fa6f71af4e224c1d86be55b6b01f2288be2 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/cfcd0fa6f71af4e224c1d86be55b6b01f2288be2 | 2021-01-06 14:20:53-05:00 |
Fix TLS issues with large replies (#10909)
This problem was introduced by 496375f and seems to more easily reproduce on macOS since OpenSSL writes more frequently return with EAGAIN. | 0b645d63193fb18a6646def558c37f6c7ee5d740 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/0b645d63193fb18a6646def558c37f6c7ee5d740 | 2022-07-03 13:35:58+03:00 |
Fix missing separator in module info line (usedby and using lists) (#9241)
Fix module info genModulesInfoStringRenderModulesList lack separator when there's more than one module in the list.
Co-authored-by: Oran Agra <[email protected]> | 1895e134a77efd789b1a6daee76a6ba5ec90e516 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/1895e134a77efd789b1a6daee76a6ba5ec90e516 | 2021-07-19 16:10:25+08:00 |
fix sprintf and snprintf format string
There are some cases of printing unsigned integer with %d conversion
specificator and vice versa (signed integer with %u specificator).
Patch by Sergey Polovko. Backported to Redis from Disque.
| 96628cc40df778716b70f4b661ceb1bd329591dd | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/96628cc40df778716b70f4b661ceb1bd329591dd | 2015-11-28 09:05:41+01:00 |
Fix the bug that CLIENT REPLY OFF|SKIP cannot receive push notifications (#11875)
This bug seems to be there forever, CLIENT REPLY OFF|SKIP will
mark the client with CLIENT_REPLY_OFF or CLIENT_REPLY_SKIP flags.
With these flags, prepareClientToWrite called by addReply* will
return C_ERR directly. So the client can't receive the Pub/Sub
messages and any other push notifications, e.g client side tracking.
In this PR, we adding a CLIENT_PUSHING flag, disables the reply
silencing flags. When adding push replies, set the flag, after the reply,
clear the flag. Then add the flag check in prepareClientToWrite.
Fixes #11874
Note, the SUBSCRIBE command response is a bit awkward,
see https://github.com/redis/redis-doc/pull/2327
Co-authored-by: Oran Agra <[email protected]> | 416842e6c004dbd951e398a8651df6c56a030a23 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/416842e6c004dbd951e398a8651df6c56a030a23 | 2023-03-12 23:50:44+08:00 |
Remove dead code from lpStringToInt64() (#8863)
| bcf1b384e3a2cc83124684a9d952682b713fe2f0 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/bcf1b384e3a2cc83124684a9d952682b713fe2f0 | 2021-04-27 07:40:58+08:00 |
Fix redis_check_rdb() hang when rdb is FIFO (#12022)
When loading RDB over the named piped, redis_check_rdb() is hung at fopen, because fopen blocks until another process opens the FIFO for writing. The fix is to check if RDB is FIFO. If yes, return an error. | d5d56d0d95d295ed7fb6bff1bc6b0c182dacbfa2 | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/d5d56d0d95d295ed7fb6bff1bc6b0c182dacbfa2 | 2023-04-14 19:14:27-04:00 |
Fixes `CLUSTER COUNTKEYSINSLOT` (#9672)
Introduced via typo in #9504.
Also adds a sanity test for coverage. | 48e4d7709961f7e1ca94dea86ff3b57c4b9710ec | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/48e4d7709961f7e1ca94dea86ff3b57c4b9710ec | 2021-10-24 12:32:53+03:00 |
Better error message const correctness. (#8348)
| 3f3cb9d09b815869764e74dd52af1994fed55fe6 | redis | neuralsentry | 0 | https://github.com/redis/redis | https://github.com/redis/redis/commit/3f3cb9d09b815869764e74dd52af1994fed55fe6 | 2021-01-21 11:56:08+02:00 |
GEOSEARCH bybox bug fixes and new fuzzy tester (#8445)
Fix errors of GEOSEARCH bybox search due to:
1. projection of the box to a trapezoid (when the meter box is converted to long / lat it's no longer a box).
2. width and height mismatch
Changes:
- New GEOSEARCH point in rectangle algorithm
- Fix GEOSEARCH bybox width and height mismatch bug
- Add GEOSEARCH bybox testing to the existing "GEOADD + GEORANGE randomized test"
- Add new fuzzy test to stress test the bybox corners and edges
- Add some tests for edge cases of the bybox algorithm
Co-authored-by: Oran Agra <[email protected]> | ded1655d49950afd02bb3c5199bd33caac995e7c | redis | neuralsentry | 1 | https://github.com/redis/redis | https://github.com/redis/redis/commit/ded1655d49950afd02bb3c5199bd33caac995e7c | 2021-02-05 00:08:35+08:00 |